Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Issue 2441153002: [sql] Test helpers to ease testing of simple queries. (Closed)

Created:
4 years, 2 months ago by Scott Hess - ex-Googler
Modified:
4 years, 1 month ago
Reviewers:
michaeln
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[sql] Test helpers to ease testing of simple queries. ExecuteWithResult() returns the first column of the first row as a string, ExecuteWithResults() formats the results with column and row separators. They make it easier to check results using EXPECT_EQ(). BUG=none Committed: https://crrev.com/1f955b18617428d0a4e203f4dce6da87c5cb8de9 Cr-Commit-Position: refs/heads/master@{#427520}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -39 lines) Patch
M sql/recovery_unittest.cc View 6 chunks +11 lines, -39 lines 0 comments Download
M sql/test/test_helpers.h View 1 chunk +21 lines, -0 lines 0 comments Download
M sql/test/test_helpers.cc View 1 chunk +23 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 14 (9 generated)
Scott Hess - ex-Googler
A little cleanup. Removed the special NULL and BLOB handling as there's no reason that ...
4 years, 2 months ago (2016-10-21 21:38:23 UTC) #2
michaeln
lgtm
4 years, 1 month ago (2016-10-24 23:55:16 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2441153002/1
4 years, 1 month ago (2016-10-25 22:13:23 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-25 22:59:32 UTC) #12
commit-bot: I haz the power
4 years, 1 month ago (2016-10-25 23:03:19 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1f955b18617428d0a4e203f4dce6da87c5cb8de9
Cr-Commit-Position: refs/heads/master@{#427520}

Powered by Google App Engine
This is Rietveld 408576698