Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(749)

Unified Diff: chrome/browser/chromeos/set_time_dialog.h

Issue 2441133002: mash: Introduce ShowWebDialogWithContainer for webui dialogs (Closed)
Patch Set: review comments Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/chromeos/set_time_dialog.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/set_time_dialog.h
diff --git a/chrome/browser/chromeos/set_time_dialog.h b/chrome/browser/chromeos/set_time_dialog.h
index e0970b7ecd51079f954d0a475f27ca5e6fbf7579..7ca03b894ebac0ce553d47936eab8b4a115a864d 100644
--- a/chrome/browser/chromeos/set_time_dialog.h
+++ b/chrome/browser/chromeos/set_time_dialog.h
@@ -18,12 +18,22 @@ namespace chromeos {
// Set Time dialog for setting the system time, date and time zone.
class SetTimeDialog : public ui::WebDialogDelegate {
public:
+ // Shows the dialog as a child of |parent|, for example the webui settings
+ // window.
+ static void ShowDialogInParent(gfx::NativeWindow parent);
+
+ // Shows the dialog in a given container in the ash window hierarchy. Used
+ // when there is no explicit parent, for example at the login screen where
+ // the general settings window is not available. |container_id| is an
+ // an ash window container id. See ash/public/cpp/shell_window_ids.h.
+ static void ShowDialogInContainer(int container_id);
+
+ private:
SetTimeDialog();
~SetTimeDialog() override;
- static void ShowDialog(gfx::NativeWindow owning_window);
+ static void ShowDialogImpl(gfx::NativeWindow parent, int container_id);
- private:
// ui::WebDialogDelegate:
ui::ModalType GetDialogModalType() const override;
base::string16 GetDialogTitle() const override;
« no previous file with comments | « no previous file | chrome/browser/chromeos/set_time_dialog.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698