[sql] Verify that Raze() works for multiple pages sizes.

[sql] Verify that Raze() works for multiple pages sizes.

Verify that sql::Connection::Raze() maintains the page size if
set_page_size() was called on the database.  Also verify that Raze()
uses the SQLite default page size if no page size was explicitly set.

BUG=none

Committed: https://crrev.com/7e2babaf656c3991ab091a7d49012240d458ce4c
Cr-Commit-Position: refs/heads/master@{#428220}

[Scott Hess - ex-Googler, 2016-10-21 22:19:14]

The CQ bit was checked by shess@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-21 22:19:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Scott Hess - ex-Googler, 2016-10-22 00:13:22]

shess@chromium.org changed reviewers:
+ michaeln@chromium.org

[Scott Hess - ex-Googler, 2016-10-22 00:13:23]

Test for another bit of sql:: which references page_size directly.

[commit-bot: I haz the power, 2016-10-22 00:27:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-22 00:27:29]

Dry run: This issue passed the CQ dry run.

[michaeln, 2016-10-25 00:01:13]

lgtm

https://codereview.chromium.org/2441103003/diff/1/sql/connection_unittest.cc
File sql/connection_unittest.cc (right):

https://codereview.chromium.org/2441103003/diff/1/sql/connection_unittest.cc#...
sql/connection_unittest.cc:522: db().set_page_size(2048);  // Not the old or new
default.
maybe assert that "2048" != default_page_size

[Scott Hess - ex-Googler, 2016-10-27 23:22:25]

EXPECT_NO_FATAL_FAILURE() with helper.

[Scott Hess - ex-Googler, 2016-10-27 23:28:07]

On 2016/10/27 23:22:25, Scott Hess wrote:
> EXPECT_NO_FATAL_FAILURE() with helper.

That was more trouble than it was worth.  The case testing how things work when
the default page size changes didn't work.  Eventually I traced it down to the
page_size immediately after sqlite3_backup being the same as before, even though
the database itself was different.  AFIACT, this doesn't actually break anything
other than tests which verify things by calling PRAGMA page_size.  So I reported
that upstream, and now I'm just going to pusha the button, since this is just
the same change you approved in the Recovery version.

[Scott Hess - ex-Googler, 2016-10-27 23:28:11]

The CQ bit was checked by shess@chromium.org

[Scott Hess - ex-Googler, 2016-10-27 23:28:11]

The patchset sent to the CQ was uploaded after l-g-t-m from
michaeln@chromium.org
Link to the patchset: https://codereview.chromium.org/2441103003/#ps20001
(title: "EXPECT_NO_FATAL_FAILURE() with helper.")

[commit-bot: I haz the power, 2016-10-27 23:29:03]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-27 23:46:35]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-10-27 23:49:51]

Description was changed from

==========
[sql] Verify that Raze() works for multiple pages sizes.

Verify that sql::Connection::Raze() maintains the page size if
set_page_size() was called on the database.  Also verify that Raze()
uses the SQLite default page size if no page size was explicitly set.

BUG=none
==========

to

==========
[sql] Verify that Raze() works for multiple pages sizes.

Verify that sql::Connection::Raze() maintains the page size if
set_page_size() was called on the database.  Also verify that Raze()
uses the SQLite default page size if no page size was explicitly set.

BUG=none

Committed: https://crrev.com/7e2babaf656c3991ab091a7d49012240d458ce4c
Cr-Commit-Position: refs/heads/master@{#428220}
==========

[commit-bot: I haz the power, 2016-10-27 23:49:52]

Patchset 2 (id:??) landed as
https://crrev.com/7e2babaf656c3991ab091a7d49012240d458ce4c
Cr-Commit-Position: refs/heads/master@{#428220}