Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issue 2441073002: Fix http_server_response_test.dart not to use snapshots as its data. (Closed)

Created:
4 years, 2 months ago by rmacnak
Modified:
4 years, 2 months ago
Reviewers:
Florian Schneider
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix http_server_response_test.dart not to use snapshots as its data. Fixes #27633 R=fschneider@google.com Committed: https://github.com/dart-lang/sdk/commit/1627c700355e46cf4f7033d27d5a816a9b739fe2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -6 lines) Patch
M tests/standalone/io/http_server_response_test.dart View 4 chunks +9 lines, -3 lines 0 comments Download
M tests/standalone/standalone.status View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
rmacnak
4 years, 2 months ago (2016-10-21 18:07:55 UTC) #2
Florian Schneider
lgtm
4 years, 2 months ago (2016-10-21 19:32:04 UTC) #3
rmacnak
4 years, 2 months ago (2016-10-21 20:56:59 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
1627c700355e46cf4f7033d27d5a816a9b739fe2 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698