Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Unified Diff: ui/webui/resources/cr_elements/cr_dialog/cr_dialog.html

Issue 2441043004: Accessibility fixes for quick unlock settings. (Closed)
Patch Set: Initial patch Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/webui/resources/cr_elements/cr_dialog/cr_dialog.html
diff --git a/ui/webui/resources/cr_elements/cr_dialog/cr_dialog.html b/ui/webui/resources/cr_elements/cr_dialog/cr_dialog.html
index fffe3dd9a4f8c797332d4e5063e17d139f491a35..7d9fd677c3fb14931d233b2cdb15e96e7da2116e 100644
--- a/ui/webui/resources/cr_elements/cr_dialog/cr_dialog.html
+++ b/ui/webui/resources/cr_elements/cr_dialog/cr_dialog.html
@@ -1,6 +1,7 @@
<link rel="import" href="chrome://resources/cr_elements/icons.html">
<link rel="import" href="chrome://resources/html/assert.html">
<link rel="import" href="chrome://resources/html/polymer.html">
+<link rel="import" href="chrome://resources/html/i18n_behavior.html">
<link rel="import" href="chrome://resources/polymer/v1_0/paper-icon-button/paper-icon-button.html">
<dom-module id="cr-dialog">
@@ -92,7 +93,8 @@
</style>
<div class="title-container">
<content select=".title"></content>
- <paper-icon-button icon="cr:clear" on-tap="cancel" id="close">
+ <paper-icon-button icon="cr:clear" on-tap="cancel" id="close"
+ alt$="[[getCloseA11yText_()]]">
tommycli 2016/10/25 18:13:50 Can you use the $i18n{} macro here?
jdufault 2016/10/26 22:38:36 Nope :(. The other files in cr_elements/* use the
tommycli 2016/10/27 00:13:25 Ah. A little gross, but if the other cr_elements d
Dan Beam 2016/10/27 01:25:48 which other elements? the ones i've used generall
jdufault 2016/10/27 19:13:55 cr_policy_indicator_behavior.js, cr_network_select
</paper-icon-button>
</div>
<div class="body-container">

Powered by Google App Engine
This is Rietveld 408576698