Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(240)

Side by Side Diff: ui/webui/resources/cr_elements/cr_dialog/cr_dialog.js

Issue 2441043004: Accessibility fixes for quick unlock settings. (Closed)
Patch Set: Initial patch Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 /** 5 /**
6 * @fileoverview 'cr-dialog' is a component for showing a modal dialog. If the 6 * @fileoverview 'cr-dialog' is a component for showing a modal dialog. If the
7 * dialog is closed via close(), a 'close' event is fired. If the dialog is 7 * dialog is closed via close(), a 'close' event is fired. If the dialog is
8 * canceled via cancel(), a 'cancel' event is fired followed by a 'close' event. 8 * canceled via cancel(), a 'cancel' event is fired followed by a 'close' event.
9 * Additionally clients can inspect the dialog's |returnValue| property inside 9 * Additionally clients can inspect the dialog's |returnValue| property inside
10 * the 'close' event listener to determine whether it was canceled or just 10 * the 'close' event listener to determine whether it was canceled or just
11 * closed, where a truthy value means success, and a falsy value means it was 11 * closed, where a truthy value means success, and a falsy value means it was
12 * canceled. 12 * canceled.
13 */ 13 */
14 Polymer({ 14 Polymer({
15 is: 'cr-dialog', 15 is: 'cr-dialog',
16 extends: 'dialog', 16 extends: 'dialog',
17 17
18 behaviors: [I18nBehavior],
tommycli 2016/10/25 18:13:50 hopefully this is unneeded per the previous commen
jdufault 2016/10/26 22:38:36 It's needed :(. I could remove it by calling loadT
19
18 /** @override */ 20 /** @override */
19 created: function() { 21 created: function() {
20 // If the active history entry changes (i.e. user clicks back button), 22 // If the active history entry changes (i.e. user clicks back button),
21 // all open dialogs should be cancelled. 23 // all open dialogs should be cancelled.
22 window.addEventListener('popstate', function() { 24 window.addEventListener('popstate', function() {
23 if (this.open) 25 if (this.open)
24 this.cancel(); 26 this.cancel();
25 }.bind(this)); 27 }.bind(this));
26 }, 28 },
27 29
28 cancel: function() { 30 cancel: function() {
29 this.fire('cancel'); 31 this.fire('cancel');
30 HTMLDialogElement.prototype.close.call(this, ''); 32 HTMLDialogElement.prototype.close.call(this, '');
31 }, 33 },
32 34
33 /** 35 /**
34 * @param {string=} opt_returnValue 36 * @param {string=} opt_returnValue
35 * @override 37 * @override
36 */ 38 */
37 close: function(opt_returnValue) { 39 close: function(opt_returnValue) {
38 HTMLDialogElement.prototype.close.call(this, 'success'); 40 HTMLDialogElement.prototype.close.call(this, 'success');
39 }, 41 },
40 42
41 /** @return {!PaperIconButtonElement} */ 43 /** @return {!PaperIconButtonElement} */
42 getCloseButton: function() { 44 getCloseButton: function() {
43 return this.$.close; 45 return this.$.close;
44 }, 46 },
47
48 getCloseA11yText_: function() {
49 return this.i18n('close');
50 }
45 }); 51 });
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698