Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(353)

Side by Side Diff: chrome/browser/ui/webui/options/options_ui.cc

Issue 2441043004: Accessibility fixes for quick unlock settings. (Closed)
Patch Set: Address comments Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/webui/options/options_ui.h" 5 #include "chrome/browser/ui/webui/options/options_ui.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 #include <utility> 8 #include <utility>
9 #include <vector> 9 #include <vector>
10 10
(...skipping 115 matching lines...) Expand 10 before | Expand all | Expand 10 after
126 constexpr char kPasswordPromptDialogJSPath[] = 126 constexpr char kPasswordPromptDialogJSPath[] =
127 "people_page/password_prompt_dialog.js"; 127 "people_page/password_prompt_dialog.js";
128 constexpr char kLockStateBehaviorHTMLPath[] = 128 constexpr char kLockStateBehaviorHTMLPath[] =
129 "people_page/lock_state_behavior.html"; 129 "people_page/lock_state_behavior.html";
130 constexpr char kLockStateBehaviorJSPath[] = 130 constexpr char kLockStateBehaviorJSPath[] =
131 "people_page/lock_state_behavior.js"; 131 "people_page/lock_state_behavior.js";
132 constexpr char kLockScreenHTMLPath[] = "people_page/lock_screen.html"; 132 constexpr char kLockScreenHTMLPath[] = "people_page/lock_screen.html";
133 constexpr char kLockScreenJSPath[] = "people_page/lock_screen.js"; 133 constexpr char kLockScreenJSPath[] = "people_page/lock_screen.js";
134 constexpr char kSetupPinHTMLPath[] = "people_page/setup_pin_dialog.html"; 134 constexpr char kSetupPinHTMLPath[] = "people_page/setup_pin_dialog.html";
135 constexpr char kSetupPinJSPath[] = "people_page/setup_pin_dialog.js"; 135 constexpr char kSetupPinJSPath[] = "people_page/setup_pin_dialog.js";
136 constexpr char kSettingsI18nSetupHTMLPath[] = "i18n_setup.html";
137 constexpr char kSettingsI18nSetupJSPath[] = "i18n_setup.js";
Dan Beam 2016/10/29 00:11:18 revert
jdufault 2016/10/31 21:10:29 Done.
136 constexpr char kSettingsRouteHTMLPath[] = "route.html"; 138 constexpr char kSettingsRouteHTMLPath[] = "route.html";
137 constexpr char kSettingsRouteJSPath[] = "route.js"; 139 constexpr char kSettingsRouteJSPath[] = "route.js";
138 constexpr char kSettingsSharedCSSHTMLPath[] = "settings_shared_css.html"; 140 constexpr char kSettingsSharedCSSHTMLPath[] = "settings_shared_css.html";
139 constexpr char kSettingsVarsCSSHTMLPath[] = "settings_vars_css.html"; 141 constexpr char kSettingsVarsCSSHTMLPath[] = "settings_vars_css.html";
140 constexpr char kSettingsPrefsBehaviorHTMLPath[] = "prefs/prefs_behavior.html"; 142 constexpr char kSettingsPrefsBehaviorHTMLPath[] = "prefs/prefs_behavior.html";
141 constexpr char kSettingsPrefsBehaviorJSPath[] = "prefs/prefs_behavior.js"; 143 constexpr char kSettingsPrefsBehaviorJSPath[] = "prefs/prefs_behavior.js";
142 constexpr char kSettingsPrefsTypesHTMLPath[] = "prefs/prefs_types.html"; 144 constexpr char kSettingsPrefsTypesHTMLPath[] = "prefs/prefs_types.html";
143 constexpr char kSettingsPrefsTypesJSPath[] = "prefs/prefs_types.js"; 145 constexpr char kSettingsPrefsTypesJSPath[] = "prefs/prefs_types.js";
144 constexpr char kOptionsPolymerHTMLPath[] = "options_polymer.html"; 146 constexpr char kOptionsPolymerHTMLPath[] = "options_polymer.html";
145 #endif 147 #endif
(...skipping 112 matching lines...) Expand 10 before | Expand all | Expand 10 after
258 path_to_idr_map_[kPasswordPromptDialogJSPath] = 260 path_to_idr_map_[kPasswordPromptDialogJSPath] =
259 IDR_OPTIONS_PASSWORD_PROMPT_DIALOG_JS; 261 IDR_OPTIONS_PASSWORD_PROMPT_DIALOG_JS;
260 path_to_idr_map_[kLockStateBehaviorHTMLPath] = 262 path_to_idr_map_[kLockStateBehaviorHTMLPath] =
261 IDR_OPTIONS_LOCK_STATE_BEHAVIOR_HTML; 263 IDR_OPTIONS_LOCK_STATE_BEHAVIOR_HTML;
262 path_to_idr_map_[kLockStateBehaviorJSPath] = 264 path_to_idr_map_[kLockStateBehaviorJSPath] =
263 IDR_OPTIONS_LOCK_STATE_BEHAVIOR_JS; 265 IDR_OPTIONS_LOCK_STATE_BEHAVIOR_JS;
264 path_to_idr_map_[kLockScreenHTMLPath] = IDR_OPTIONS_LOCK_SCREEN_HTML; 266 path_to_idr_map_[kLockScreenHTMLPath] = IDR_OPTIONS_LOCK_SCREEN_HTML;
265 path_to_idr_map_[kLockScreenJSPath] = IDR_OPTIONS_LOCK_SCREEN_JS; 267 path_to_idr_map_[kLockScreenJSPath] = IDR_OPTIONS_LOCK_SCREEN_JS;
266 path_to_idr_map_[kSetupPinHTMLPath] = IDR_OPTIONS_SETUP_PIN_DIALOG_HTML; 268 path_to_idr_map_[kSetupPinHTMLPath] = IDR_OPTIONS_SETUP_PIN_DIALOG_HTML;
267 path_to_idr_map_[kSetupPinJSPath] = IDR_OPTIONS_SETUP_PIN_DIALOG_JS; 269 path_to_idr_map_[kSetupPinJSPath] = IDR_OPTIONS_SETUP_PIN_DIALOG_JS;
270 path_to_idr_map_[kSettingsI18nSetupHTMLPath] = IDR_SETTINGS_I18N_SETUP_HTML;
271 path_to_idr_map_[kSettingsI18nSetupJSPath] = IDR_SETTINGS_I18N_SETUP_JS;
Dan Beam 2016/10/29 00:11:18 revert
jdufault 2016/10/31 21:10:29 Done.
268 path_to_idr_map_[kSettingsRouteHTMLPath] = IDR_OPTIONS_ROUTE_HTML; 272 path_to_idr_map_[kSettingsRouteHTMLPath] = IDR_OPTIONS_ROUTE_HTML;
269 path_to_idr_map_[kSettingsRouteJSPath] = IDR_OPTIONS_ROUTE_JS; 273 path_to_idr_map_[kSettingsRouteJSPath] = IDR_OPTIONS_ROUTE_JS;
270 path_to_idr_map_[kSettingsSharedCSSHTMLPath] = IDR_SETTINGS_SHARED_CSS_HTML; 274 path_to_idr_map_[kSettingsSharedCSSHTMLPath] = IDR_SETTINGS_SHARED_CSS_HTML;
271 path_to_idr_map_[kSettingsVarsCSSHTMLPath] = IDR_SETTINGS_VARS_CSS_HTML; 275 path_to_idr_map_[kSettingsVarsCSSHTMLPath] = IDR_SETTINGS_VARS_CSS_HTML;
272 path_to_idr_map_[kSettingsPrefsBehaviorHTMLPath] = 276 path_to_idr_map_[kSettingsPrefsBehaviorHTMLPath] =
273 IDR_SETTINGS_PREFS_BEHAVIOR_HTML; 277 IDR_SETTINGS_PREFS_BEHAVIOR_HTML;
274 path_to_idr_map_[kSettingsPrefsBehaviorJSPath] = 278 path_to_idr_map_[kSettingsPrefsBehaviorJSPath] =
275 IDR_SETTINGS_PREFS_BEHAVIOR_JS; 279 IDR_SETTINGS_PREFS_BEHAVIOR_JS;
276 path_to_idr_map_[kSettingsPrefsTypesHTMLPath] = IDR_SETTINGS_PREFS_TYPES_HTML; 280 path_to_idr_map_[kSettingsPrefsTypesHTMLPath] = IDR_SETTINGS_PREFS_TYPES_HTML;
277 path_to_idr_map_[kSettingsPrefsTypesJSPath] = IDR_SETTINGS_PREFS_TYPES_JS; 281 path_to_idr_map_[kSettingsPrefsTypesJSPath] = IDR_SETTINGS_PREFS_TYPES_JS;
(...skipping 291 matching lines...) Expand 10 before | Expand all | Expand 10 after
569 // Add only if handler's service is enabled. 573 // Add only if handler's service is enabled.
570 if (handler->IsEnabled()) { 574 if (handler->IsEnabled()) {
571 // Add handler to the list and also pass the ownership. 575 // Add handler to the list and also pass the ownership.
572 web_ui()->AddMessageHandler(handler.release()); 576 web_ui()->AddMessageHandler(handler.release());
573 handler_raw->GetLocalizedValues(localized_strings); 577 handler_raw->GetLocalizedValues(localized_strings);
574 handlers_.push_back(handler_raw); 578 handlers_.push_back(handler_raw);
575 } 579 }
576 } 580 }
577 581
578 } // namespace options 582 } // namespace options
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698