Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(884)

Unified Diff: third_party/WebKit/Source/core/input/MouseEventManager.cpp

Issue 2441023003: Align drag feedback for links with draggable="true" to Safari. (Closed)
Patch Set: Rebased, added dependency on CL that fixes testing logistical issue. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/input/MouseEventManager.cpp
diff --git a/third_party/WebKit/Source/core/input/MouseEventManager.cpp b/third_party/WebKit/Source/core/input/MouseEventManager.cpp
index 92deb7c26787c5854fd1489be7ff588db0f2b205..1083ad074db497b26d3a4bd65c331b85f6c58ab4 100644
--- a/third_party/WebKit/Source/core/input/MouseEventManager.cpp
+++ b/third_party/WebKit/Source/core/input/MouseEventManager.cpp
@@ -811,23 +811,6 @@ bool MouseEventManager::tryStartDrag(
dragState().m_dragDataTransfer = createDraggingDataTransfer();
- // Check to see if this a DOM based drag, if it is get the DOM specified drag
- // image and offset
- if (dragState().m_dragType == DragSourceActionDHTML) {
- if (LayoutObject* layoutObject = dragState().m_dragSrc->layoutObject()) {
- IntRect boundingIncludingDescendants =
- layoutObject->absoluteBoundingBoxRectIncludingDescendants();
- IntSize delta = m_mouseDownPos - boundingIncludingDescendants.location();
- dragState().m_dragDataTransfer->setDragImageElement(
- dragState().m_dragSrc.get(), IntPoint(delta));
- } else {
- // The layoutObject has disappeared, this can happen if the onStartDrag
- // handler has hidden the element in some way. In this case we just kill
- // the drag.
- return false;
- }
- }
-
DragController& dragController = m_frame->page()->dragController();
if (!dragController.populateDragDataTransfer(m_frame, dragState(),
m_mouseDownPos))

Powered by Google App Engine
This is Rietveld 408576698