third_party/WebKit/LayoutTests/fast/dnd/link-dragging-draggable-div-with-dragged-link.html - Issue 2441023003: Align drag feedback for links with draggable="true" to Safari.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/fast/dnd/link-dragging-draggable-div-with-dragged-link.html

Issue 2441023003: Align drag feedback for links with draggable="true" to Safari. (Closed)

Patch Set: Attempted to address feedback. Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/fast/dnd/link-dragging-draggable-div-with-dragged-link-expected.txt » ('j') | third_party/WebKit/Source/core/page/DragController.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <script src="../../resources/ahem.js"></script>

	3 <link rel="stylesheet" href="resources/link-dragging-common.css" />

	4 <script src="../../resources/testharness.js"></script>

	5 <script src="../../resources/testharnessreport.js"></script>

	6 <script src="resources/link-dragging-common.js"></script>

	7

	8 <p>

	9 Please drag the "Drag Me" text into the "Drop Here" rectangle.

	10 </p>

	11

	12 <article>

	13 <div class="box" draggable="true">

	14 <a class="dragged" href="https://www.chromium.org">

	15 Drag Me - drag the text, not the box

	16 </a>

	17 </div>

	18 <div class="dropzone box">

	19 Drop Here

	20 </div>

	21 </article>

	22

	23 <script>

	24

	25 promise_test((t) => {

	26 return runLinkDraggingTest(t, {
	dcheng 2016/10/31 22:31:34 Nit: it's useful to document the expected result h Nit: it's useful to document the expected result here. For example, maybe the test could assert what event.target is (for example, from this test, I'm not 100% sure if we're dragging just the <a> element or the <div> as well. pwnall 2016/11/04 23:08:29 Done. Good point! All the tests drag the element w Show quoted text On 2016/10/31 22:31:34, dcheng wrote: > Nit: it's useful to document the expected result here. For example, maybe the > test could assert what event.target is (for example, from this test, I'm not > 100% sure if we're dragging just the <a> element or the <div> as well. Done. Good point! All the tests drag the element with the class "draggable", so I added an assertion to make sure that the dragged element has the class "draggable".
	27 dragStartUriList: 'https://www.chromium.org/',

	28 dragStartTypes: ['text/html', 'text/plain', 'text/uri-list'],

	29 });

	30 }, 'Link inside div with draggable="true"');

	31

	32 </script>

OLD	NEW