Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(389)

Issue 2440913003: Fix issue with broken links in HyperlinkTextView. (Closed)

Created:
4 years, 2 months ago by Justin Donnelly
Modified:
4 years, 1 month ago
Reviewers:
Robert Sesek, shrike
CC:
chromium-reviews, mac-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix issue with broken links in HyperlinkTextView. If a link in a HyperlinkTextView does not begin at the start of the text then a click that looks like a potential text selection will fail to activate the link. BUG=626021 Committed: https://crrev.com/9d159f8f03b89122f247478a0dde2e9c15e2ccea Cr-Commit-Position: refs/heads/master@{#427111}

Patch Set 1 #

Patch Set 2 : Add unit test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -2 lines) Patch
M ui/base/cocoa/controls/hyperlink_text_view.mm View 1 chunk +6 lines, -2 lines 0 comments Download
M ui/base/cocoa/controls/hyperlink_text_view_unittest.mm View 1 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (10 generated)
Justin Donnelly
4 years, 2 months ago (2016-10-21 17:02:34 UTC) #5
shrike
lgtm rsesek@ - this was my suggested change to fix a problem with clicking links ...
4 years, 2 months ago (2016-10-21 17:14:47 UTC) #6
Robert Sesek
Fix makes sense, but can you add a unittest?
4 years, 1 month ago (2016-10-24 15:21:26 UTC) #9
Justin Donnelly
On 2016/10/24 15:21:26, Robert Sesek wrote: > Fix makes sense, but can you add a ...
4 years, 1 month ago (2016-10-24 16:33:02 UTC) #10
Robert Sesek
LGTM
4 years, 1 month ago (2016-10-24 18:08:45 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2440913003/20001
4 years, 1 month ago (2016-10-24 18:10:14 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-10-24 19:04:40 UTC) #16
commit-bot: I haz the power
4 years, 1 month ago (2016-10-24 19:23:45 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/9d159f8f03b89122f247478a0dde2e9c15e2ccea
Cr-Commit-Position: refs/heads/master@{#427111}

Powered by Google App Engine
This is Rietveld 408576698