Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(481)

Unified Diff: services/service_manager/tests/connect/connect_unittest.cc

Issue 2440903002: Make "all user" services work when packaged. (Closed)
Patch Set: Addressed latest comments and synced. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: services/service_manager/tests/connect/connect_unittest.cc
diff --git a/services/service_manager/tests/connect/connect_unittest.cc b/services/service_manager/tests/connect/connect_unittest.cc
index c13ee74ffd1d965891cc7f358f1d033cf4d92247..3a58334c76415d0d784a701616ab6229562ee66a 100644
--- a/services/service_manager/tests/connect/connect_unittest.cc
+++ b/services/service_manager/tests/connect/connect_unittest.cc
@@ -208,32 +208,6 @@ TEST_F(ConnectTest, Instances) {
EXPECT_NE(instance_a1, instance_b);
}
-// When both the unresolved and resolved instance names are their default
-// values, the instance name from the unresolved name must be used.
-// (The case where the instance names differ is covered by
-// LifecycleTest.PackagedApp_CrashCrashesOtherProvidedApp).
-TEST_F(ConnectTest, PreferUnresolvedDefaultInstanceName) {
- // Connect to an app with no manifest-supplied instance name provided by a
- // package, the instance name must be derived from the application instance
- // name, not the package.
- std::unique_ptr<Connection> connection = connector()->Connect(kTestAppName);
- {
- base::RunLoop loop;
- connection->AddConnectionCompletedClosure(base::Bind(&QuitLoop, &loop));
- loop.Run();
- }
-
- std::string instance;
- {
- test::mojom::ConnectTestServicePtr service;
- connection->GetInterface(&service);
- base::RunLoop loop;
- service->GetInstance(base::Bind(&ReceiveOneString, &instance, &loop));
- loop.Run();
- }
- EXPECT_EQ(GetNamePath(kTestAppName), instance);
-}
-
// BlockedInterface should not be exposed to this application because it is not
// in our CapabilityFilter whitelist.
TEST_F(ConnectTest, BlockedInterface) {
« no previous file with comments | « services/service_manager/switches.cc ('k') | services/service_manager/tests/lifecycle/lifecycle_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698