[Contextual Search] Pipe basic quick action data from C++ to Java

[Contextual Search] Pipe basic quick action data from C++ to Java

This CL adds basic scaffolding for passing quick action data from
the native ContextualSearchDelegate to Java through the search
term resolution response.

BUG=657063
Committed: https://crrev.com/7a71a1fa240458697111bb6a27aed0804b6b20bd
Cr-Commit-Position: refs/heads/master@{#427115}

[Theresa, 2016-10-20 22:49:53]

The CQ bit was checked by twellington@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-20 22:50:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Theresa, 2016-10-20 23:03:07]

The CQ bit was checked by twellington@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-20 23:03:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Theresa, 2016-10-20 23:03:51]

twellington@chromium.org changed reviewers:
+ donnd@chromium.org

[Theresa, 2016-10-20 23:03:52]

ptal - this is pretty basic scaffolding with more TODO's than implementation.
After this lands it should be easier to split up some of the quick actions work.

https://codereview.chromium.org/2440843002/diff/20001/chrome/browser/android/...
File chrome/browser/android/contextualsearch/contextual_search_delegate.cc
(right):

https://codereview.chromium.org/2440843002/diff/20001/chrome/browser/android/...
chrome/browser/android/contextualsearch/contextual_search_delegate.cc:524: //
TODO(donnd): parse information about quick action uri and category.
Donn, is it okay if I assign this TODO to you?

[Donn Denman, 2016-10-20 23:30:19]

LGTM with just one action item to consider.

https://codereview.chromium.org/2440843002/diff/20001/chrome/browser/android/...
File chrome/browser/android/contextualsearch/contextual_search_delegate.cc
(right):

https://codereview.chromium.org/2440843002/diff/20001/chrome/browser/android/...
chrome/browser/android/contextualsearch/contextual_search_delegate.cc:524: //
TODO(donnd): parse information about quick action uri and category.
On 2016/10/20 23:03:52, Theresa Wellington wrote:
> Donn, is it okay if I assign this TODO to you?

Sure!

https://codereview.chromium.org/2440843002/diff/20001/chrome/browser/android/...
File chrome/browser/android/contextualsearch/resolved_search_term.cc (right):

https://codereview.chromium.org/2440843002/diff/20001/chrome/browser/android/...
chrome/browser/android/contextualsearch/resolved_search_term.cc:9:
ResolvedSearchTerm::ResolvedSearchTerm(int response_code)
I think we need/want some additional initializers in this constructor too:
      quick_action_uri(""),
      quick_action_category("")

[Donn Denman, 2016-10-20 23:30:46]

Thanks for doing this!

[Theresa, 2016-10-20 23:42:36]

https://codereview.chromium.org/2440843002/diff/20001/chrome/browser/android/...
File chrome/browser/android/contextualsearch/resolved_search_term.cc (right):

https://codereview.chromium.org/2440843002/diff/20001/chrome/browser/android/...
chrome/browser/android/contextualsearch/resolved_search_term.cc:9:
ResolvedSearchTerm::ResolvedSearchTerm(int response_code)
On 2016/10/20 23:30:19, Donn Denman wrote:
> I think we need/want some additional initializers in this constructor too:
>       quick_action_uri(""),
>       quick_action_category("")

Done.

[Theresa, 2016-10-20 23:43:32]

The CQ bit was checked by twellington@chromium.org

[Theresa, 2016-10-20 23:43:33]

The patchset sent to the CQ was uploaded after l-g-t-m from donnd@chromium.org
Link to the patchset: https://codereview.chromium.org/2440843002/#ps40001
(title: "[Contextual Search] Pipe basic quick action data from C++ to Java")

[commit-bot: I haz the power, 2016-10-20 23:44:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-21 00:40:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-21 00:40:21]

Try jobs failed on following builders:
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)

[Donn Denman, 2016-10-21 00:43:10]

On 2016/10/21 00:40:21, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
>
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)

Theresa, looks like you just need to update the native delegate unittest.

[Theresa, 2016-10-21 16:27:30]

The CQ bit was checked by twellington@chromium.org

[Theresa, 2016-10-21 16:27:32]

The patchset sent to the CQ was uploaded after l-g-t-m from donnd@chromium.org
Link to the patchset: https://codereview.chromium.org/2440843002/#ps60001
(title: "Fix unittest")

[commit-bot: I haz the power, 2016-10-21 16:27:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-21 17:26:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-21 17:26:06]

Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)

[Theresa, 2016-10-21 18:17:37]

The CQ bit was checked by twellington@chromium.org

[Theresa, 2016-10-21 18:17:38]

The patchset sent to the CQ was uploaded after l-g-t-m from donnd@chromium.org
Link to the patchset: https://codereview.chromium.org/2440843002/#ps80001
(title: "Fix instrumentation tests")

[commit-bot: I haz the power, 2016-10-21 18:18:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-21 21:57:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-21 21:57:09]

Try jobs failed on following builders:
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)

[Theresa, 2016-10-24 15:26:42]

The CQ bit was checked by twellington@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-24 15:27:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-24 16:07:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-24 16:07:41]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[Theresa, 2016-10-24 16:15:49]

The CQ bit was checked by twellington@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-24 16:16:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Theresa, 2016-10-24 16:31:15]

The CQ bit was unchecked by twellington@chromium.org

[Theresa, 2016-10-24 16:31:15]

The CQ bit was checked by twellington@chromium.org

[Theresa, 2016-10-24 16:31:16]

The patchset sent to the CQ was uploaded after l-g-t-m from donnd@chromium.org
Link to the patchset: https://codereview.chromium.org/2440843002/#ps120001
(title: "[Contextual Search] Pipe basic quick action data from C++ to Java")

[commit-bot: I haz the power, 2016-10-24 16:31:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-24 17:52:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-24 17:52:04]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Theresa, 2016-10-24 17:53:12]

The CQ bit was checked by twellington@chromium.org

[commit-bot: I haz the power, 2016-10-24 17:53:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-24 19:26:59]

Committed patchset #7 (id:120001)

[commit-bot: I haz the power, 2016-10-24 19:55:40]

Description was changed from

==========
[Contextual Search] Pipe basic quick action data from C++ to Java

This CL adds basic scaffolding for passing quick action data from
the native ContextualSearchDelegate to Java through the search
term resolution response.

BUG=657063
==========

to

==========
[Contextual Search] Pipe basic quick action data from C++ to Java

This CL adds basic scaffolding for passing quick action data from
the native ContextualSearchDelegate to Java through the search
term resolution response.

BUG=657063

Committed: https://crrev.com/7a71a1fa240458697111bb6a27aed0804b6b20bd
Cr-Commit-Position: refs/heads/master@{#427115}
==========

[commit-bot: I haz the power, 2016-10-24 19:55:42]

Patchset 7 (id:??) landed as
https://crrev.com/7a71a1fa240458697111bb6a27aed0804b6b20bd
Cr-Commit-Position: refs/heads/master@{#427115}