Issue 2440813002: [Merge] Fix WelcomeHandler crash when signin link is clicked.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2440813002: [Merge] Fix WelcomeHandler crash when signin link is clicked. (Closed)

Created:
4 years, 2 months ago by anthonyvd

Modified:
4 years, 2 months ago

Reviewers:

CC:
chromium-reviews

Target Ref:
refs/pending/branch-heads/2883

Project:
chromium

Visibility:
Public.

[Merge] Fix WelcomeHandler crash when signin link is clicked. BUG=656153 Review-Url: https://codereview.chromium.org/2431543003 Cr-Commit-Position: refs/heads/master@{#426092} (cherry picked from commit 9ae964cc90a742835cd7c86d8c2d249dde19b4e4) Committed: https://chromium.googlesource.com/chromium/src/+/4c184ff72b80c664143f4968afd2a8f8b4227c16

Created: 4 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -4 lines)			Patch
	M	chrome/browser/ui/webui/welcome_handler.h	View		1 chunk	+2 lines, -1 line	0 comments	Download
	M	chrome/browser/ui/webui/welcome_handler.cc	View		3 chunks	+11 lines, -3 lines	0 comments	Download

Total messages: 2 (1 generated)

anthonyvd

4 years, 2 months ago (2016-10-20 20:18:22 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
4c184ff72b80c664143f4968afd2a8f8b4227c16.