third_party/WebKit/Source/core/html/parser/HTMLResourcePreloaderTest.cpp - Issue 2440803002: Filter out data urls in the preload scanner

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/parser/HTMLResourcePreloaderTest.cpp

Issue 2440803002: Filter out data urls in the preload scanner (Closed)

Patch Set: nits and test Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/html/parser/HTMLResourcePreloader.cpp ('k') | third_party/WebKit/Source/core/html/parser/PreloadRequest.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/parser/HTMLResourcePreloaderTest.cpp

diff --git a/third_party/WebKit/Source/core/html/parser/HTMLResourcePreloaderTest.cpp b/third_party/WebKit/Source/core/html/parser/HTMLResourcePreloaderTest.cpp

index c28df17d67dd1c3a10c6f8d4fe8b4d677a552e88..30160fc2711ed1e803e900c9c8458ccbe51ee48e 100644

--- a/third_party/WebKit/Source/core/html/parser/HTMLResourcePreloaderTest.cpp

+++ b/third_party/WebKit/Source/core/html/parser/HTMLResourcePreloaderTest.cpp

@@ -49,11 +49,12 @@ class HTMLResourcePreloaderTest : public testing::Test {

// TODO(yoav): Need a mock loader here to verify things are happenning

// beyond preconnect.

PreloaderNetworkHintsMock networkHints;

- std::unique_ptr<PreloadRequest> preloadRequest = PreloadRequest::create(

+ auto preloadRequest = PreloadRequest::createIfNeeded(

String(), TextPosition(), testCase.url,

KURL(ParsedURLStringTag(), testCase.baseURL), Resource::Image,

ReferrerPolicy(), FetchRequest::ResourceWidth(),

ClientHintsPreferences(), PreloadRequest::RequestTypePreconnect);

+ DCHECK(preloadRequest);

if (testCase.isCORS)

preloadRequest->setCrossOrigin(CrossOriginAttributeAnonymous);

HTMLResourcePreloader* preloader =