Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(403)

Unified Diff: third_party/WebKit/Source/core/html/parser/HTMLResourcePreloaderTest.cpp

Issue 2440803002: Filter out data urls in the preload scanner (Closed)
Patch Set: yoav comments Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/html/parser/HTMLResourcePreloaderTest.cpp
diff --git a/third_party/WebKit/Source/core/html/parser/HTMLResourcePreloaderTest.cpp b/third_party/WebKit/Source/core/html/parser/HTMLResourcePreloaderTest.cpp
index c28df17d67dd1c3a10c6f8d4fe8b4d677a552e88..8326807b93f94012f7398c57190e01dfb1aff5dc 100644
--- a/third_party/WebKit/Source/core/html/parser/HTMLResourcePreloaderTest.cpp
+++ b/third_party/WebKit/Source/core/html/parser/HTMLResourcePreloaderTest.cpp
@@ -49,11 +49,12 @@ class HTMLResourcePreloaderTest : public testing::Test {
// TODO(yoav): Need a mock loader here to verify things are happenning
// beyond preconnect.
PreloaderNetworkHintsMock networkHints;
- std::unique_ptr<PreloadRequest> preloadRequest = PreloadRequest::create(
- String(), TextPosition(), testCase.url,
- KURL(ParsedURLStringTag(), testCase.baseURL), Resource::Image,
- ReferrerPolicy(), FetchRequest::ResourceWidth(),
- ClientHintsPreferences(), PreloadRequest::RequestTypePreconnect);
+ std::unique_ptr<PreloadRequest> preloadRequest =
Yoav Weiss 2016/10/25 04:34:14 ditto
Charlie Harrison 2016/10/25 13:32:48 Done.
+ PreloadRequest::createIfNeeded(
+ String(), TextPosition(), testCase.url,
+ KURL(ParsedURLStringTag(), testCase.baseURL), Resource::Image,
+ ReferrerPolicy(), FetchRequest::ResourceWidth(),
+ ClientHintsPreferences(), PreloadRequest::RequestTypePreconnect);
if (testCase.isCORS)
Yoav Weiss 2016/10/25 04:34:14 Assuming we're certain here that request was creat
Charlie Harrison 2016/10/25 13:32:48 Done.
preloadRequest->setCrossOrigin(CrossOriginAttributeAnonymous);
HTMLResourcePreloader* preloader =

Powered by Google App Engine
This is Rietveld 408576698