Filter out data urls in the preload scanner

third_party/WebKit/Source/core/html/parser/HTMLPreloadScanner.cpp

 /*
  * Copyright (C) 2008 Apple Inc. All Rights Reserved.
  * Copyright (C) 2009 Torch Mobile, Inc. http://www.torchmobile.com/
  * Copyright (C) 2010 Google Inc. All Rights Reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
@@ skipping 223 matching lines @@
 
     Resource::Type type;
     if (!resourceType(type))
       return nullptr;
 
     // The element's 'referrerpolicy' attribute (if present) takes precedence
     // over the document's referrer policy.
     ReferrerPolicy referrerPolicy = (m_referrerPolicy != ReferrerPolicyDefault)
                                         ? m_referrerPolicy
                                         : documentReferrerPolicy;
-    std::unique_ptr<PreloadRequest> request = PreloadRequest::create(
+    std::unique_ptr<PreloadRequest> request = PreloadRequest::createIfNeeded(

[Yoav Weiss, 2016/10/25 04:34:14]

same nit: should we auto this variable?

[Charlie Harrison, 2016/10/25 13:32:48]

Done.

         initiatorFor(m_tagImpl), position, m_urlToLoad, predictedBaseURL, type,
         referrerPolicy, resourceWidth, clientHintsPreferences, requestType);
+    if (!request)
+      return nullptr;
+
     request->setCrossOrigin(m_crossOrigin);
     request->setNonce(m_nonce);
     request->setCharset(charset());
     request->setDefer(m_defer);
     request->setIntegrityMetadata(m_integrityMetadata);
 
     // TODO(csharrison): Once this is deprecated, just abort the request here.
     if (match(m_tagImpl, scriptTag) &&
         !ScriptLoader::isValidScriptTypeAndLanguage(
             m_typeAttributeValue, m_languageAttributeValue,
@@ skipping 635 matching lines @@
   defaultViewportMinWidth = document->viewportDefaultMinWidth();
   viewportMetaZeroValuesQuirk =
       document->settings() &&
       document->settings()->viewportMetaZeroValuesQuirk();
   viewportMetaEnabled =
       document->settings() && document->settings()->viewportMetaEnabled();
   referrerPolicy = document->getReferrerPolicy();
 }
 
 }  // namespace blink