Filter out data urls in the preload scanner

third_party/WebKit/Source/core/html/parser/PreloadRequest.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef PreloadRequest_h
 #define PreloadRequest_h
 
 #include "core/fetch/ClientHintsPreferences.h"
 #include "core/fetch/FetchRequest.h"
 #include "core/fetch/IntegrityMetadata.h"
@@ skipping 12 matching lines @@
 class PreloadRequest {
   USING_FAST_MALLOC(PreloadRequest);
 
  public:
   enum RequestType {
     RequestTypePreload,
     RequestTypePreconnect,
     RequestTypeLinkRelPreload
   };
 
+  // TODO(csharrison): Move the implementation to the cpp file when html
+  // gets its own testing source set in html/BUILD.gn.
   static std::unique_ptr<PreloadRequest> create(

[Yoav Weiss, 2016/10/24 15:00:32]

Usually `create()` doesn't fail in normal circumstances. Could you rename to
createIfNeeded() or something similar?

[Charlie Harrison, 2016/10/24 17:39:48]

Done.

       const String& initiatorName,
       const TextPosition& initiatorPosition,
       const String& resourceURL,
       const KURL& baseURL,
       Resource::Type resourceType,
       const ReferrerPolicy referrerPolicy,
       const FetchRequest::ResourceWidth& resourceWidth =
           FetchRequest::ResourceWidth(),
       const ClientHintsPreferences& clientHintsPreferences =
           ClientHintsPreferences(),
       RequestType requestType = RequestTypePreload) {
+    // Never preload data or ref urls.
+    if (resourceURL.isEmpty() || resourceURL.startsWith("#") ||

[Yoav Weiss, 2016/10/24 14:43:54]

Are absolute ref URLs an issue? What would happen with them?

[Charlie Harrison, 2016/10/24 14:49:31]

I think absolute ref URLs are okay because we really just don't want the URL to
canonicalize into a data URL. This will happen with relative ref URLs but not
absolute ref URLs. I can probably amend this comment to make that a little
clearer.

[Yoav Weiss, 2016/10/24 15:00:32]

Thanks. Clarifying that in the comment would be indeed helpful.

[Charlie Harrison, 2016/10/24 17:39:48]

Done.

+        protocolIs(resourceURL, "data")) {
+      return nullptr;
+    }
     return wrapUnique(new PreloadRequest(
         initiatorName, initiatorPosition, resourceURL, baseURL, resourceType,
         resourceWidth, clientHintsPreferences, requestType, referrerPolicy));
   }
 
   bool isSafeToSendToAnotherThread() const;
 
   FetchRequest resourceRequest(Document*);
 
   const String& charset() const { return m_charset; }
@@ skipping 78 matching lines @@
 
   // Used for deprecation warnings.
   bool m_hasInvalidTypeOrLanguage = false;
 };
 
 typedef Vector<std::unique_ptr<PreloadRequest>> PreloadRequestStream;
 
 }  // namespace blink
 
 #endif