Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(348)

Issue 24407003: Generate the Chrome policy schema at compile time. (Closed)

Created:
7 years, 3 months ago by Joao da Silva
Modified:
7 years, 1 month ago
CC:
chromium-reviews
Visibility:
Public.

Description

Generate the Chrome policy schema at compile time. The schema is represented by static structures that are generated at compile time, so that no parsing is required at runtime. BUG=270667

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+115 lines, -2 lines) Patch
M chrome/browser/policy/browser_policy_connector.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/tools/build/generate_policy_source.py View 6 chunks +113 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Joao da Silva
Here's the generator CL, if you want to have a look. Unfortunately this requires a ...
7 years, 3 months ago (2013-09-24 17:57:50 UTC) #1
Mattias Nissler (ping if slow)
Have you figured out why the relocations are required?
7 years, 3 months ago (2013-09-24 18:47:40 UTC) #2
Joao da Silva
7 years, 2 months ago (2013-09-25 07:42:57 UTC) #3
On 2013/09/24 18:47:40, Mattias Nissler wrote:
> Have you figured out why the relocations are required?

Not yet. A static build surprisingly has the same problem; this may be due to
PIC. I'll see if that can be disabled for this file and whether it makes a
difference.

I did notice that if &kSchema doesn't escape the policy_constants.cc translation
unit then no relocations are generated, and the size increases by the expected
3K. But as soon as the getter exists AND is called from
browser_policy_connector.cc then the relocations are introduced again.

Powered by Google App Engine
This is Rietveld 408576698