Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Side by Side Diff: components/cronet/android/BUILD.gn

Issue 2440613003: [Cronet] Enforce implementation does not call through API classes (Closed)
Patch Set: finish Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2015 The Chromium Authors. All rights reserved. 1 # Copyright 2015 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/buildflag_header.gni") 5 import("//build/buildflag_header.gni")
6 import("//build/config/android/config.gni") 6 import("//build/config/android/config.gni")
7 import("//build/config/android/rules.gni") 7 import("//build/config/android/rules.gni")
8 import("//build/util/process_version.gni") 8 import("//build/util/process_version.gni")
9 import("//build/util/version.gni") 9 import("//build/util/version.gni")
10 import("//testing/test.gni") 10 import("//testing/test.gni")
(...skipping 1079 matching lines...) Expand 10 before | Expand all | Expand 10 after
1090 rebase_path("$root_out_dir/obj/base/base/*.o", root_build_dir), 1090 rebase_path("$root_out_dir/obj/base/base/*.o", root_build_dir),
1091 "--stamp", 1091 "--stamp",
1092 rebase_path(outputs[0], root_build_dir), 1092 rebase_path(outputs[0], root_build_dir),
1093 ] 1093 ]
1094 deps = [ 1094 deps = [
1095 "//base:base", 1095 "//base:base",
1096 ] 1096 ]
1097 } 1097 }
1098 } 1098 }
1099 1099
1100 # Enforce restrictions for API<->impl boundary.
1101 action("api_static_checks") {
1102 script = "//components/cronet/tools/api_static_checks.py"
1103 outputs = [
1104 "$target_gen_dir/$target_name.stamp",
1105 ]
1106 args = [
1107 "--api_jar",
1108 rebase_path(
1109 "$root_out_dir/lib.java/components/cronet/android/cronet_api.jar",
1110 root_build_dir),
1111 "--impl_jar",
1112 rebase_path(
1113 "$root_out_dir/lib.java/components/cronet/android/cronet_impl_common_jav a.jar",
1114 root_build_dir),
1115 "--impl_jar",
1116 rebase_path(
1117 "$root_out_dir/lib.java/components/cronet/android/cronet_impl_platform_j ava.jar",
1118 root_build_dir),
1119 "--impl_jar",
1120 rebase_path(
1121 "$root_out_dir/lib.java/components/cronet/android/cronet_impl_native_jav a.jar",
1122 root_build_dir),
1123 "--stamp",
1124 rebase_path(outputs[0], root_build_dir),
1125 ]
1126 deps = [
1127 ":cronet_api_java",
1128 ":cronet_impl_common_java",
1129 ":cronet_impl_native_java",
1130 ":cronet_impl_platform_java",
1131 ]
1132 }
1133
1100 group("cronet_package") { 1134 group("cronet_package") {
1101 # Enforce that arm_use_neon==false when building for ARMv7 by 1135 # Enforce that arm_use_neon==false when building for ARMv7 by
1102 # not including any deps in cronet_package target otherwise. 1136 # not including any deps in cronet_package target otherwise.
1103 if (!(target_cpu == "arm" && arm_version == 7) || !arm_use_neon) { 1137 if (!(target_cpu == "arm" && arm_version == 7) || !arm_use_neon) {
1104 deps = [ 1138 deps = [
1139 ":api_static_checks",
1105 ":cronet_combine_proguard_flags", 1140 ":cronet_combine_proguard_flags",
1106 ":cronet_package_copy", 1141 ":cronet_package_copy",
1107 ":cronet_package_copy_native_lib", 1142 ":cronet_package_copy_native_lib",
1108 ":cronet_package_copy_native_lib_unstripped", 1143 ":cronet_package_copy_native_lib_unstripped",
1109 ":generate_javadoc", 1144 ":generate_javadoc",
1110 ":generate_licenses", 1145 ":generate_licenses",
1111 ":jar_cronet_api_source", 1146 ":jar_cronet_api_source",
1112 ":jar_cronet_impl_common_java_source", 1147 ":jar_cronet_impl_common_java_source",
1113 ":jar_cronet_impl_native_java_source", 1148 ":jar_cronet_impl_native_java_source",
1114 ":jar_cronet_impl_platform_java_source", 1149 ":jar_cronet_impl_platform_java_source",
1115 ":jar_cronet_sample_source", 1150 ":jar_cronet_sample_source",
1116 ":repackage_extracted_jars", 1151 ":repackage_extracted_jars",
1117 ] 1152 ]
1118 if (current_cpu == "arm" && arm_version == 7) { 1153 if (current_cpu == "arm" && arm_version == 7) {
1119 deps += [ ":enforce_no_neon" ] 1154 deps += [ ":enforce_no_neon" ]
1120 } 1155 }
1121 } 1156 }
1122 } 1157 }
OLDNEW
« no previous file with comments | « no previous file | components/cronet/tools/api_static_checks.py » ('j') | components/cronet/tools/api_static_checks.py » ('J')

Powered by Google App Engine
This is Rietveld 408576698