Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Side by Side Diff: components/cronet/android/BUILD.gn

Issue 2440613003: [Cronet] Enforce implementation does not call through API classes (Closed)
Patch Set: add exception for Exception.getMessage() call Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « components/cronet/PRESUBMIT.py ('k') | components/cronet/tools/__init__.py » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2015 The Chromium Authors. All rights reserved. 1 # Copyright 2015 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/buildflag_header.gni") 5 import("//build/buildflag_header.gni")
6 import("//build/config/android/config.gni") 6 import("//build/config/android/config.gni")
7 import("//build/config/android/rules.gni") 7 import("//build/config/android/rules.gni")
8 import("//build/util/process_version.gni") 8 import("//build/util/process_version.gni")
9 import("//build/util/version.gni") 9 import("//build/util/version.gni")
10 import("//testing/test.gni") 10 import("//testing/test.gni")
(...skipping 1385 matching lines...) Expand 10 before | Expand all | Expand 10 after
1396 rebase_path("$root_out_dir/obj/base/base/*.o", root_build_dir), 1396 rebase_path("$root_out_dir/obj/base/base/*.o", root_build_dir),
1397 "--stamp", 1397 "--stamp",
1398 rebase_path(outputs[0], root_build_dir), 1398 rebase_path(outputs[0], root_build_dir),
1399 ] 1399 ]
1400 deps = [ 1400 deps = [
1401 "//base:base", 1401 "//base:base",
1402 ] 1402 ]
1403 } 1403 }
1404 } 1404 }
1405 1405
1406 # Enforce restrictions for API<->impl boundary.
1407 action("api_static_checks") {
1408 script = "//components/cronet/tools/api_static_checks.py"
1409 outputs = [
1410 "$target_gen_dir/$target_name.stamp",
1411 ]
1412 args = [
1413 "--api_jar",
1414 rebase_path(
1415 "$root_out_dir/lib.java/components/cronet/android/cronet_api.jar",
1416 root_build_dir),
1417 "--impl_jar",
1418 rebase_path(
1419 "$root_out_dir/lib.java/components/cronet/android/cronet_impl_common_jav a.jar",
1420 root_build_dir),
1421 "--impl_jar",
1422 rebase_path(
1423 "$root_out_dir/lib.java/components/cronet/android/cronet_impl_platform_j ava.jar",
1424 root_build_dir),
1425 "--impl_jar",
1426 rebase_path(
1427 "$root_out_dir/lib.java/components/cronet/android/cronet_impl_native_jav a.jar",
1428 root_build_dir),
1429 "--stamp",
1430 rebase_path(outputs[0], root_build_dir),
1431 ]
1432 deps = [
1433 ":cronet_api_java",
1434 ":cronet_impl_common_java",
1435 ":cronet_impl_native_java",
1436 ":cronet_impl_platform_java",
1437 ]
1438 }
1439
1406 group("cronet_package") { 1440 group("cronet_package") {
1407 # Marked as testonly as it contains test-only targets too. 1441 # Marked as testonly as it contains test-only targets too.
1408 testonly = true 1442 testonly = true
1409 1443
1410 # Enforce building with ICU alternatives, crbug.com/611621. 1444 # Enforce building with ICU alternatives, crbug.com/611621.
1411 # Enforce that arm_use_neon==false when building for ARMv7 by 1445 # Enforce that arm_use_neon==false when building for ARMv7 by
1412 # not including any deps in cronet_package target otherwise. 1446 # not including any deps in cronet_package target otherwise.
1413 if (use_platform_icu_alternatives && 1447 if (use_platform_icu_alternatives &&
1414 (!(target_cpu == "arm" && arm_version == 7) || !arm_use_neon)) { 1448 (!(target_cpu == "arm" && arm_version == 7) || !arm_use_neon)) {
1415 deps = [ 1449 deps = [
1450 ":api_static_checks",
1416 ":cronet_package_copy", 1451 ":cronet_package_copy",
1417 ":cronet_package_copy_native_lib", 1452 ":cronet_package_copy_native_lib",
1418 ":cronet_package_copy_native_lib_unstripped", 1453 ":cronet_package_copy_native_lib_unstripped",
1419 ":cronet_test_package", 1454 ":cronet_test_package",
1420 ":generate_javadoc", 1455 ":generate_javadoc",
1421 ":generate_licenses", 1456 ":generate_licenses",
1422 ":jar_cronet_api_source", 1457 ":jar_cronet_api_source",
1423 ":jar_cronet_impl_common_java_source", 1458 ":jar_cronet_impl_common_java_source",
1424 ":jar_cronet_impl_native_java_source", 1459 ":jar_cronet_impl_native_java_source",
1425 ":jar_cronet_impl_platform_java_source", 1460 ":jar_cronet_impl_platform_java_source",
(...skipping 14 matching lines...) Expand all
1440 deps = [ 1475 deps = [
1441 ":cronet_package_copy_native_test_lib", 1476 ":cronet_package_copy_native_test_lib",
1442 ":cronet_package_copy_native_test_lib_unstripped", 1477 ":cronet_package_copy_native_test_lib_unstripped",
1443 ":cronet_package_copy_test_assets", 1478 ":cronet_package_copy_test_assets",
1444 ":cronet_package_copy_test_files", 1479 ":cronet_package_copy_test_files",
1445 ":cronet_package_copy_test_support_apks", 1480 ":cronet_package_copy_test_support_apks",
1446 ":repackage_extracted_test_jars", 1481 ":repackage_extracted_test_jars",
1447 ] 1482 ]
1448 } 1483 }
1449 } 1484 }
OLDNEW
« no previous file with comments | « components/cronet/PRESUBMIT.py ('k') | components/cronet/tools/__init__.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698