third_party/WebKit/Source/modules/webaudio/MediaStreamAudioDestinationNode.cpp - Issue 2440583002: Use AudioUtilities::kRenderQuantumFrames everywhere

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/webaudio/MediaStreamAudioDestinationNode.cpp

Issue 2440583002: Use AudioUtilities::kRenderQuantumFrames everywhere (Closed)

Patch Set: Address review comments Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/webaudio/GainNode.cpp ('k') | third_party/WebKit/Source/modules/webaudio/OscillatorNode.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/webaudio/MediaStreamAudioDestinationNode.cpp

diff --git a/third_party/WebKit/Source/modules/webaudio/MediaStreamAudioDestinationNode.cpp b/third_party/WebKit/Source/modules/webaudio/MediaStreamAudioDestinationNode.cpp

index 0c01d9d309cc4dd03e229a832c942c6cf4e96db5..29fb96a68bbff989771eedb476e651c3f2699bf4 100644

--- a/third_party/WebKit/Source/modules/webaudio/MediaStreamAudioDestinationNode.cpp

+++ b/third_party/WebKit/Source/modules/webaudio/MediaStreamAudioDestinationNode.cpp

@@ -47,7 +47,8 @@ MediaStreamAudioDestinationHandler::MediaStreamAudioDestinationHandler(

node,

node.context()->sampleRate(),

numberOfChannels),

- m_mixBus(AudioBus::create(numberOfChannels, ProcessingSizeInFrames)) {

+ m_mixBus(AudioBus::create(numberOfChannels,

+ AudioUtilities::kRenderQuantumFrames)) {

m_source = MediaStreamSource::create(

"WebAudio-" + createCanonicalUUIDString(), MediaStreamSource::TypeAudio,

"MediaStreamAudioDestinationNode", false,

@@ -91,7 +92,7 @@ void MediaStreamAudioDestinationHandler::process(size_t numberOfFrames) {

if (tryLocker.locked()) {

unsigned count = channelCount();

if (count != m_mixBus->numberOfChannels()) {

- m_mixBus = AudioBus::create(count, ProcessingSizeInFrames);

+ m_mixBus = AudioBus::create(count, AudioUtilities::kRenderQuantumFrames);

// setAudioFormat has an internal lock. This can cause audio to

// glitch. This is outside of our control.

m_source->setAudioFormat(count, context()->sampleRate());