third_party/WebKit/Source/modules/webaudio/DelayDSPKernel.cpp - Issue 2440583002: Use AudioUtilities::kRenderQuantumFrames everywhere

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/webaudio/DelayDSPKernel.cpp

Issue 2440583002: Use AudioUtilities::kRenderQuantumFrames everywhere (Closed)

Patch Set: Address review comments Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/modules/webaudio/DelayDSPKernel.cpp

diff --git a/third_party/WebKit/Source/modules/webaudio/DelayDSPKernel.cpp b/third_party/WebKit/Source/modules/webaudio/DelayDSPKernel.cpp

index 3ec87ba83ba41ac9f6d14e8458969f930b410eae..cc63f89fef8c37e16148f7303e42a5c9c4ff116b 100644

--- a/third_party/WebKit/Source/modules/webaudio/DelayDSPKernel.cpp

+++ b/third_party/WebKit/Source/modules/webaudio/DelayDSPKernel.cpp

@@ -33,7 +33,7 @@ namespace blink {

const float SmoothingTimeConstant = 0.020f; // 20ms

DelayDSPKernel::DelayDSPKernel(DelayProcessor* processor)

- : AudioDelayDSPKernel(processor, AudioHandler::ProcessingSizeInFrames) {

+ : AudioDelayDSPKernel(processor, AudioUtilities::kRenderQuantumFrames) {

DCHECK(processor);

DCHECK_GT(processor->sampleRate(), 0);

if (!(processor && processor->sampleRate() > 0))