media/test/pipeline_integration_test_base.cc - Issue 2440563004: Switch to using an explicit ended signal instead of time comparison.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/test/pipeline_integration_test_base.cc

Issue 2440563004: Switch to using an explicit ended signal instead of time comparison. (Closed)

Patch Set: Fix ended event in ARI. Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: media/test/pipeline_integration_test_base.cc

diff --git a/media/test/pipeline_integration_test_base.cc b/media/test/pipeline_integration_test_base.cc

index 5b50e9f23af325e70f9a7116552864e20f7216bf..371e1ea80fee4afc56e0093f475c08a7160edb09 100644

--- a/media/test/pipeline_integration_test_base.cc

+++ b/media/test/pipeline_integration_test_base.cc

@@ -141,7 +141,7 @@ PipelineStatus PipelineIntegrationTestBase::StartInternal(

.Times(AnyNumber());

EXPECT_CALL(*this, OnBufferingStateChange(BUFFERING_HAVE_NOTHING))

.Times(AnyNumber());

- EXPECT_CALL(*this, OnDurationChange()).Times(AtMost(1));

+ EXPECT_CALL(*this, OnDurationChange()).Times(AnyNumber());

EXPECT_CALL(*this, OnVideoNaturalSizeChange(_)).Times(AtMost(1));

EXPECT_CALL(*this, OnVideoOpacityChange(_)).Times(AtMost(1));

CreateDemuxer(std::move(data_source));