Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(807)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: media/renderers/audio_renderer_impl.cc

Issue 2440563004: Switch to using an explicit ended signal instead of time comparison. (Closed)
Patch Set: Fix ended event in ARI. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/filters/ffmpeg_demuxer_unittest.cc ('k') | media/test/pipeline_integration_test.cc » ('j') | third_party/WebKit/Source/core/html/HTMLMediaElement.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/renderers/audio_renderer_impl.cc
diff --git a/media/renderers/audio_renderer_impl.cc b/media/renderers/audio_renderer_impl.cc
index 379c9570b114175ad358f3c31ec1e0f9af0f2759..4510c0916410b2dba93d330df2a47c153f4ab4f8 100644
--- a/media/renderers/audio_renderer_impl.cc
+++ b/media/renderers/audio_renderer_impl.cc
@@ -646,6 +646,12 @@ bool AudioRendererImpl::HandleSplicerBuffer_Locked(
lock_.AssertAcquired();
if (buffer->end_of_stream()) {
received_end_of_stream_ = true;
+ if (!algorithm_->frames_buffered()) {
+ rendered_end_of_stream_ = true;
+ task_runner_->PostTask(FROM_HERE,
+ base::Bind(&AudioRendererImpl::OnPlaybackEnded,
+ weak_factory_.GetWeakPtr()));
+ }
} else {
if (state_ == kPlaying) {
if (IsBeforeStartTime(buffer))
« no previous file with comments | « media/filters/ffmpeg_demuxer_unittest.cc ('k') | media/test/pipeline_integration_test.cc » ('j') | third_party/WebKit/Source/core/html/HTMLMediaElement.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698