Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Unified Diff: media/blink/webmediaplayer_impl.cc

Issue 2440563004: Switch to using an explicit ended signal instead of time comparison. (Closed)
Patch Set: Fix ended event in ARI. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/blink/webmediaplayer_impl.cc
diff --git a/media/blink/webmediaplayer_impl.cc b/media/blink/webmediaplayer_impl.cc
index fdb43c9b95f20f2f20306af96881bb45bbe2a27d..034ce359ee265224135ab45dc623f7d1818a4e5b 100644
--- a/media/blink/webmediaplayer_impl.cc
+++ b/media/blink/webmediaplayer_impl.cc
@@ -1104,7 +1104,7 @@ void WebMediaPlayerImpl::OnEnded() {
return;
ended_ = true;
- client_->timeChanged();
+ client_->timeChanged(ended_);
// We don't actually want this to run until |client_| calls seek() or pause(),
// but that should have already happened in timeChanged() and so this is
@@ -1174,7 +1174,7 @@ void WebMediaPlayerImpl::OnBufferingStateChange(BufferingState state) {
// Blink expects a timeChanged() in response to a seek().
if (should_notify_time_changed_)
- client_->timeChanged();
+ client_->timeChanged(ended_);
// Once we have enough, start reporting the total memory usage. We'll also
// report once playback starts.
@@ -1364,7 +1364,7 @@ void WebMediaPlayerImpl::OnRemotePlaybackEnded() {
DCHECK(main_task_runner_->BelongsToCurrentThread());
ended_ = true;
- client_->timeChanged();
+ client_->timeChanged(ended_);
}
void WebMediaPlayerImpl::OnDisconnectedFromRemoteDevice(double t) {

Powered by Google App Engine
This is Rietveld 408576698