Add EscapeURL to the ASCII escape methods....

Add EscapeURL to the ASCII escape methods.  EscapeURL escapes all forbidden ascii characters in an URL and replaces spaces with '+'.

Test=Escape.EscapeUrl
BUG=23029
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=27713

[tim (not reviewing), 2009-10-01 02:57:53]

This LGTM because it is taken from internal impl of a similar function that is
used by our servers for escaping, and by virtue of the fact that it was
originally written by the One they call Jeff.

You may want to add a comment similar to what is found there (in url.h), in that
this is not necessarily the inverse of Unescape (we also treat spaces specially,
for example. See UnescapeRule).

+cc Brett for FYI purposes, as he is one of the keepers of this code, afaik.

[tim (not reviewing), 2009-10-01 02:58:28]

(actually +cc)

[brettw, 2009-10-01 03:13:17]

Is the change description wrong? I don't see it replaces space with a plus.

[brg_google.com, 2009-10-01 06:48:55]

The |true| parameter in the escape method causes space to be replaced with plus.

On Wed, Sep 30, 2009 at 8:13 PM,  <brettw@chromium.org> wrote:
> Is the change description wrong? I don't see it replaces space with a plus.
>
> http://codereview.chromium.org/244056
>

[brettw, 2009-10-01 17:16:45]

Okay, I get the plus.

Can you clarify what this is used for? You have a URL, and now you need to
escape it for what purpose. Escaping #, ?, &, and % will actually corrupt the
URL and you won't be able to use it anymore.

[brg, 2009-10-01 17:37:42]

Some confusion is obviously coming from the name, which is poorly chosen.

The purpose of the method is to enocde data which is transmitted in
the applicaiton/x-www-urlencoded content type as specified here:
http://www.w3.org/TR/html401/interact/forms.html#form-content-type.
Specifically, it is what sync had used during development and is
required for decoding properly.

Perhaps its name should EscapeUrlencodedData instead of EscapeUrl.  I
will also add the first sentence of explanation above as a comment.

On Thu, Oct 1, 2009 at 10:16 AM,  <brettw@chromium.org> wrote:
>
> Okay, I get the plus.
>
> Can you clarify what this is used for? You have a URL, and now you need to
> escape it for what purpose. Escaping #, ?, &, and % will actually corrupt
> the
> URL and you won't be able to use it anymore.
>
> http://codereview.chromium.org/244056
>