Add inputmode support to content editable.

Add inputmode support to content editable.

Expose inputMode attribute on HTMLElement so that it
is available for contentEditable items as well.

BUG=642800
Committed: https://crrev.com/8134c8104b3710f57e2b8a8a979f158057a4a783
Cr-Commit-Position: refs/heads/master@{#429395}

[dtapuska, 2016-10-19 17:55:54]

The CQ bit was checked by dtapuska@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-19 17:56:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-19 19:58:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-19 19:58:04]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[dtapuska, 2016-10-26 14:59:37]

The CQ bit was checked by dtapuska@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-26 14:59:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dtapuska, 2016-10-26 15:54:13]

dtapuska@chromium.org changed reviewers:
+ ojan@chromium.org

[dtapuska, 2016-10-26 15:54:14]

Still trying to work at getting the HTML spec updated. But this is all behind an
experimental flag for now anyways.

[commit-bot: I haz the power, 2016-10-26 16:10:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-26 16:10:01]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[dtapuska, 2016-10-27 19:50:30]

The CQ bit was checked by dtapuska@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-27 19:50:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-27 20:59:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-27 20:59:28]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[dtapuska, 2016-10-28 17:35:43]

On 2016/10/26 15:54:14, dtapuska wrote:
> Still trying to work at getting the HTML spec updated. But this is all behind
an
> experimental flag for now anyways.

ping; ojan@ do you have any issues with me doing this? Should I get someone else
to review it?

[ojan, 2016-10-31 20:50:22]

lgtm

Mozilla folks at TPAC had some concerns about adding more global attributes for
editing. They were arguing for creating a new HTML element, e.g <richinput> and
putting the attributes there. At first blush, that seems reasonable to me except
that it means we need to think about how <richinput> should work by default,
e.g.

-Maybe execCommand shouldn't work on <richinput> by default? You just get
beforeInput and text insertion. You'd get execCommand if you did <richinput
contentEditable>. Or maybe it should just imply contentEditable?
-<richinput> should get beforeInput of course, but should it be focusable by
default? Probably?

That said, you don't need to block this patch on figuring all that out since
this patch is behind a flag and will be necessary even if we only expose this on
<richinput> since we'll also need inputmode on <input> and <textarea>. So, this
patch lgtm as long as you add a TODO (e.g. in the else clause that we might only
want to apply this to <richinput>.

In an ideal world, we'd someday build <input> and <textarea> on top of
<richinput>, but we don't necessarily need to start there and that would be more
of an editing team thing than input team anyways.

Lastly, what happened spec-wise with inputmode? I don't know where all that
landed.

[dtapuska, 2016-11-01 00:19:20]

On 2016/10/31 20:50:22, ojan wrote:
> lgtm
> 
> Mozilla folks at TPAC had some concerns about adding more global attributes
for
> editing. They were arguing for creating a new HTML element, e.g <richinput>
and
> putting the attributes there. At first blush, that seems reasonable to me
except
> that it means we need to think about how <richinput> should work by default,
> e.g.
> 
> -Maybe execCommand shouldn't work on <richinput> by default? You just get
> beforeInput and text insertion. You'd get execCommand if you did <richinput
> contentEditable>. Or maybe it should just imply contentEditable?
> -<richinput> should get beforeInput of course, but should it be focusable by
> default? Probably?
> 
> That said, you don't need to block this patch on figuring all that out since
> this patch is behind a flag and will be necessary even if we only expose this
on
> <richinput> since we'll also need inputmode on <input> and <textarea>. So,
this
> patch lgtm as long as you add a TODO (e.g. in the else clause that we might
only
> want to apply this to <richinput>.
> 
> In an ideal world, we'd someday build <input> and <textarea> on top of
> <richinput>, but we don't necessarily need to start there and that would be
more
> of an editing team thing than input team anyways.
> 
> Lastly, what happened spec-wise with inputmode? I don't know where all that
> landed.

The spec-wise issue is here: https://github.com/whatwg/html/issues/1897

[dtapuska, 2016-11-01 16:49:21]

The CQ bit was checked by dtapuska@chromium.org

[dtapuska, 2016-11-01 16:49:28]

The CQ bit was unchecked by dtapuska@chromium.org

[dtapuska, 2016-11-02 18:59:51]

The CQ bit was checked by dtapuska@chromium.org

[dtapuska, 2016-11-02 18:59:51]

The patchset sent to the CQ was uploaded after l-g-t-m from ojan@chromium.org
Link to the patchset: https://codereview.chromium.org/2440513002/#ps60001
(title: "Add TODO")

[commit-bot: I haz the power, 2016-11-02 19:00:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-02 20:51:35]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-11-02 20:53:53]

Description was changed from

==========
Add inputmode support to content editable.

Expose inputMode attribute on HTMLElement so that it
is available for contentEditable items as well.

BUG=642800
==========

to

==========
Add inputmode support to content editable.

Expose inputMode attribute on HTMLElement so that it
is available for contentEditable items as well.

BUG=642800

Committed: https://crrev.com/8134c8104b3710f57e2b8a8a979f158057a4a783
Cr-Commit-Position: refs/heads/master@{#429395}
==========

[commit-bot: I haz the power, 2016-11-02 20:53:54]

Patchset 4 (id:??) landed as
https://crrev.com/8134c8104b3710f57e2b8a8a979f158057a4a783
Cr-Commit-Position: refs/heads/master@{#429395}