Combine action parameters sent to Android displayNotification

chrome/browser/notifications/notification_platform_types_android.h

Index: chrome/browser/notifications/notification_platform_types_android.h
diff --git a/chrome/browser/notifications/notification_platform_types_android.h b/chrome/browser/notifications/notification_platform_types_android.h
new file mode 100644
index 0000000000000000000000000000000000000000..ca4382fb1ebac201aa875f76bb4ed16f356bb53e
--- /dev/null
+++ b/chrome/browser/notifications/notification_platform_types_android.h
@@ -0,0 +1,15 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_NOTIFICATIONS_NOTIFICATION_PLATFORM_TYPES_ANDROID_H_
+#define CHROME_BROWSER_NOTIFICATIONS_NOTIFICATION_PLATFORM_TYPES_ANDROID_H_
+
+// A Java counterpart will be generated for this enum.
+// GENERATED_JAVA_ENUM_PACKAGE: org.chromium.chrome.browser.notifications
+enum NotificationActionType {

[awdf, 2016/10/20 15:18:07]

I tried making it an enum class but that doesn't allow implicit conversion to
int values.

Also, I filed https://codereview.chromium.org/2440483002/ for the bug where it
doesn't work when the enum is all on one line. I'm happy to take this on if you
like?

[Peter Beverloo, 2016/10/20 15:36:20]

SGTM.

I think you mean https://crbug.com/657847. I wouldn't worry about fixing it,
let's focus on growing your familiarity with our own code first?

If it's just this enum, you could also decide to just define it in
notification_platform_bridge_android.cc. Up to you.

[awdf, 2016/10/20 16:05:39]

Ah yes, that's the one. I've given it the label 'Build-Tools', so maybe someone
will notice it & pick it up, let me know if there's a more specific label that
applies.
Hm, I was thinking we could put more types here if we reduce the parameter list
further, but actually that will just mean making more Java classes like
ActionInfo.java, since there's no more enums, so this new file is probably
unnecessary.

[Peter Beverloo, 2016/10/20 16:13:38]

That label sounds fine to me.

[awdf, 2016/10/20 16:35:44]

Done (put the enum in the other file and removed this new file).

Also added a comment to prevent future 'git cl format' issues.

+  BUTTON,
+  TEXT
+};
+
+#endif  // CHROME_BROWSER_NOTIFICATIONS_NOTIFICATION_PLATFORM_TYPES_ANDROID_H_