Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Side by Side Diff: chrome/android/java/src/org/chromium/chrome/browser/notifications/ActionInfo.java

Issue 2440483002: Combine action parameters sent to Android displayNotification (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 package org.chromium.chrome.browser.notifications;
6
7 import android.graphics.Bitmap;
8
9 import org.chromium.base.annotations.CalledByNative;
10 import org.chromium.base.annotations.JNINamespace;
11
12 /**
13 * Helper class for passing notification action information over the JNI.
Peter Beverloo 2016/10/20 15:36:20 Heh, funny -- this reads wrong to me, but actually
awdf 2016/10/20 16:05:39 yeah? what would you say?
Peter Beverloo 2016/10/20 16:13:38 I think this is good :). [[Insert The Social Netw
14 */
15 @JNINamespace("chrome")
Peter Beverloo 2016/10/20 15:36:20 nit: drop
awdf 2016/10/20 16:05:39 Done.
awdf 2016/10/20 16:05:39 Done.
16 class ActionInfo {
17 public final String title;
18 public final Bitmap icon;
19 public final int type;
20 public final String placeholder;
21
22 private ActionInfo(String title, Bitmap icon, int type, String placeholder) {
23 this.title = title;
24 this.icon = icon;
25 this.type = type;
26 this.placeholder = placeholder;
27 }
28
29 @CalledByNative
30 private static ActionInfo createActionInfo(
31 String title, Bitmap icon, int type, String placeholder) {
32 return new ActionInfo(title, icon, type, placeholder);
33 }
34 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698