components/policy/core/common/schema_registry_tracking_policy_provider_unittest.cc - Issue 2440473004: Add policy domain for signin screen apps

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/policy/core/common/schema_registry_tracking_policy_provider_unittest.cc

Issue 2440473004: Add policy domain for signin screen apps (Closed)

Patch Set: Fix compilation Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/policy/core/common/cloud/cloud_policy_manager.h ('K') | « components/policy/core/common/schema_registry.cc ('k') | components/policy/core/common/schema_registry_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/policy/core/common/schema_registry_tracking_policy_provider_unittest.cc

diff --git a/components/policy/core/common/schema_registry_tracking_policy_provider_unittest.cc b/components/policy/core/common/schema_registry_tracking_policy_provider_unittest.cc

index 46f503637d409c22630ba5a6c0553f5679abbb1a..cf7c61c30acca6cb688896345137c3b76f3e1895 100644

--- a/components/policy/core/common/schema_registry_tracking_policy_provider_unittest.cc

+++ b/components/policy/core/common/schema_registry_tracking_policy_provider_unittest.cc

@@ -114,6 +114,7 @@ TEST_F(SchemaRegistryTrackingPolicyProviderTest, SchemaReady) {

EXPECT_CALL(observer_, OnUpdatePolicy(&schema_registry_tracking_provider_));

schema_registry_.SetReady(POLICY_DOMAIN_CHROME);

schema_registry_.SetReady(POLICY_DOMAIN_EXTENSIONS);

+ schema_registry_.SetReady(POLICY_DOMAIN_SIGNIN_EXTENSIONS);

Mock::VerifyAndClearExpectations(&observer_);

EXPECT_TRUE(schema_registry_tracking_provider_.IsInitializationComplete(

@@ -137,6 +138,7 @@ TEST_F(SchemaRegistryTrackingPolicyProviderTest, SchemaReadyWithComponents) {

schema_registry_.RegisterComponent(

PolicyNamespace(POLICY_DOMAIN_EXTENSIONS, "xyz"), CreateTestSchema());

schema_registry_.SetReady(POLICY_DOMAIN_EXTENSIONS);

+ schema_registry_.SetReady(POLICY_DOMAIN_SIGNIN_EXTENSIONS);

Mock::VerifyAndClearExpectations(&mock_provider_);

EXPECT_CALL(mock_provider_, RefreshPolicies());

@@ -182,6 +184,7 @@ TEST_F(SchemaRegistryTrackingPolicyProviderTest, DelegateUpdates) {

EXPECT_CALL(mock_provider_, RefreshPolicies());

schema_registry_.SetReady(POLICY_DOMAIN_CHROME);

schema_registry_.SetReady(POLICY_DOMAIN_EXTENSIONS);

+ schema_registry_.SetReady(POLICY_DOMAIN_SIGNIN_EXTENSIONS);

EXPECT_TRUE(schema_registry_.IsReady());

Mock::VerifyAndClearExpectations(&mock_provider_);

EXPECT_FALSE(schema_registry_tracking_provider_.IsInitializationComplete(

@@ -208,6 +211,7 @@ TEST_F(SchemaRegistryTrackingPolicyProviderTest, RemoveAndAddComponent) {

schema_registry_.SetReady(POLICY_DOMAIN_CHROME);

schema_registry_.RegisterComponent(ns, CreateTestSchema());

schema_registry_.SetReady(POLICY_DOMAIN_EXTENSIONS);

+ schema_registry_.SetReady(POLICY_DOMAIN_SIGNIN_EXTENSIONS);

Mock::VerifyAndClearExpectations(&mock_provider_);

// Serve policy for |ns|.