Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(391)

Unified Diff: components/policy/core/common/schema_registry_tracking_policy_provider_unittest.cc

Issue 2440473004: Add policy domain for signin screen apps (Closed)
Patch Set: More comments according to feedback Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/policy/core/common/schema_registry_tracking_policy_provider_unittest.cc
diff --git a/components/policy/core/common/schema_registry_tracking_policy_provider_unittest.cc b/components/policy/core/common/schema_registry_tracking_policy_provider_unittest.cc
index 46f503637d409c22630ba5a6c0553f5679abbb1a..ca1880075bcd989e94f2636a239a74e0c4669d5e 100644
--- a/components/policy/core/common/schema_registry_tracking_policy_provider_unittest.cc
+++ b/components/policy/core/common/schema_registry_tracking_policy_provider_unittest.cc
@@ -112,8 +112,7 @@ TEST_F(SchemaRegistryTrackingPolicyProviderTest, RefreshPolicies) {
TEST_F(SchemaRegistryTrackingPolicyProviderTest, SchemaReady) {
EXPECT_CALL(observer_, OnUpdatePolicy(&schema_registry_tracking_provider_));
- schema_registry_.SetReady(POLICY_DOMAIN_CHROME);
- schema_registry_.SetReady(POLICY_DOMAIN_EXTENSIONS);
+ schema_registry_.SetAllDomainsReady();
Mock::VerifyAndClearExpectations(&observer_);
EXPECT_TRUE(schema_registry_tracking_provider_.IsInitializationComplete(
@@ -136,7 +135,7 @@ TEST_F(SchemaRegistryTrackingPolicyProviderTest, SchemaReadyWithComponents) {
EXPECT_CALL(mock_provider_, RefreshPolicies()).Times(0);
schema_registry_.RegisterComponent(
PolicyNamespace(POLICY_DOMAIN_EXTENSIONS, "xyz"), CreateTestSchema());
- schema_registry_.SetReady(POLICY_DOMAIN_EXTENSIONS);
+ schema_registry_.SetExtensionsDomainsReady();
Mock::VerifyAndClearExpectations(&mock_provider_);
EXPECT_CALL(mock_provider_, RefreshPolicies());
@@ -180,8 +179,7 @@ TEST_F(SchemaRegistryTrackingPolicyProviderTest, DelegateUpdates) {
Mock::VerifyAndClearExpectations(&observer_);
EXPECT_CALL(mock_provider_, RefreshPolicies());
- schema_registry_.SetReady(POLICY_DOMAIN_CHROME);
- schema_registry_.SetReady(POLICY_DOMAIN_EXTENSIONS);
+ schema_registry_.SetAllDomainsReady();
EXPECT_TRUE(schema_registry_.IsReady());
Mock::VerifyAndClearExpectations(&mock_provider_);
EXPECT_FALSE(schema_registry_tracking_provider_.IsInitializationComplete(
@@ -205,9 +203,8 @@ TEST_F(SchemaRegistryTrackingPolicyProviderTest, DelegateUpdates) {
TEST_F(SchemaRegistryTrackingPolicyProviderTest, RemoveAndAddComponent) {
EXPECT_CALL(mock_provider_, RefreshPolicies());
const PolicyNamespace ns(POLICY_DOMAIN_EXTENSIONS, "xyz");
- schema_registry_.SetReady(POLICY_DOMAIN_CHROME);
schema_registry_.RegisterComponent(ns, CreateTestSchema());
- schema_registry_.SetReady(POLICY_DOMAIN_EXTENSIONS);
+ schema_registry_.SetAllDomainsReady();
Mock::VerifyAndClearExpectations(&mock_provider_);
// Serve policy for |ns|.
« no previous file with comments | « components/policy/core/common/schema_registry.cc ('k') | components/policy/core/common/schema_registry_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698