Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(365)

Unified Diff: components/policy/core/common/policy_service_impl_unittest.cc

Issue 2440473004: Add policy domain for signin screen apps (Closed)
Patch Set: More comments according to feedback Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/policy/core/common/policy_service_impl_unittest.cc
diff --git a/components/policy/core/common/policy_service_impl_unittest.cc b/components/policy/core/common/policy_service_impl_unittest.cc
index 73f732431a9b41ebdfe40033db97f54bf20c182f..da73e0970d33ad8aa238833d77e1e8450355097a 100644
--- a/components/policy/core/common/policy_service_impl_unittest.cc
+++ b/components/policy/core/common/policy_service_impl_unittest.cc
@@ -572,24 +572,32 @@ TEST_F(PolicyServiceTest, IsInitializationComplete) {
EXPECT_FALSE(policy_service_->IsInitializationComplete(POLICY_DOMAIN_CHROME));
EXPECT_FALSE(
policy_service_->IsInitializationComplete(POLICY_DOMAIN_EXTENSIONS));
+ EXPECT_FALSE(policy_service_->IsInitializationComplete(
+ POLICY_DOMAIN_SIGNIN_EXTENSIONS));
// |provider2_| still doesn't have POLICY_DOMAIN_CHROME initialized, so
// the initialization status of that domain won't change.
MockPolicyServiceObserver observer;
policy_service_->AddObserver(POLICY_DOMAIN_CHROME, &observer);
policy_service_->AddObserver(POLICY_DOMAIN_EXTENSIONS, &observer);
+ policy_service_->AddObserver(POLICY_DOMAIN_SIGNIN_EXTENSIONS, &observer);
EXPECT_CALL(observer, OnPolicyServiceInitialized(_)).Times(0);
Mock::VerifyAndClearExpectations(&provider1_);
EXPECT_CALL(provider1_, IsInitializationComplete(POLICY_DOMAIN_CHROME))
.WillRepeatedly(Return(true));
EXPECT_CALL(provider1_, IsInitializationComplete(POLICY_DOMAIN_EXTENSIONS))
.WillRepeatedly(Return(false));
+ EXPECT_CALL(provider1_,
+ IsInitializationComplete(POLICY_DOMAIN_SIGNIN_EXTENSIONS))
+ .WillRepeatedly(Return(false));
const PolicyMap kPolicyMap;
provider1_.UpdateChromePolicy(kPolicyMap);
Mock::VerifyAndClearExpectations(&observer);
EXPECT_FALSE(policy_service_->IsInitializationComplete(POLICY_DOMAIN_CHROME));
EXPECT_FALSE(
policy_service_->IsInitializationComplete(POLICY_DOMAIN_EXTENSIONS));
+ EXPECT_FALSE(policy_service_->IsInitializationComplete(
+ POLICY_DOMAIN_SIGNIN_EXTENSIONS));
// Same if |provider1_| doesn't have POLICY_DOMAIN_EXTENSIONS initialized.
EXPECT_CALL(observer, OnPolicyServiceInitialized(_)).Times(0);
@@ -598,11 +606,16 @@ TEST_F(PolicyServiceTest, IsInitializationComplete) {
.WillRepeatedly(Return(false));
EXPECT_CALL(provider2_, IsInitializationComplete(POLICY_DOMAIN_EXTENSIONS))
.WillRepeatedly(Return(true));
+ EXPECT_CALL(provider2_,
+ IsInitializationComplete(POLICY_DOMAIN_SIGNIN_EXTENSIONS))
+ .WillRepeatedly(Return(true));
provider2_.UpdateChromePolicy(kPolicyMap);
Mock::VerifyAndClearExpectations(&observer);
EXPECT_FALSE(policy_service_->IsInitializationComplete(POLICY_DOMAIN_CHROME));
EXPECT_FALSE(
policy_service_->IsInitializationComplete(POLICY_DOMAIN_EXTENSIONS));
+ EXPECT_FALSE(policy_service_->IsInitializationComplete(
+ POLICY_DOMAIN_SIGNIN_EXTENSIONS));
// Now initialize POLICY_DOMAIN_CHROME on all the providers.
EXPECT_CALL(observer, OnPolicyServiceInitialized(POLICY_DOMAIN_CHROME));
@@ -611,29 +624,42 @@ TEST_F(PolicyServiceTest, IsInitializationComplete) {
.WillRepeatedly(Return(true));
EXPECT_CALL(provider2_, IsInitializationComplete(POLICY_DOMAIN_EXTENSIONS))
.WillRepeatedly(Return(true));
+ EXPECT_CALL(provider2_,
+ IsInitializationComplete(POLICY_DOMAIN_SIGNIN_EXTENSIONS))
+ .WillRepeatedly(Return(true));
provider2_.UpdateChromePolicy(kPolicyMap);
Mock::VerifyAndClearExpectations(&observer);
EXPECT_TRUE(policy_service_->IsInitializationComplete(POLICY_DOMAIN_CHROME));
// Other domains are still not initialized.
EXPECT_FALSE(
policy_service_->IsInitializationComplete(POLICY_DOMAIN_EXTENSIONS));
+ EXPECT_FALSE(policy_service_->IsInitializationComplete(
+ POLICY_DOMAIN_SIGNIN_EXTENSIONS));
// Initialize the remaining domain.
EXPECT_CALL(observer, OnPolicyServiceInitialized(POLICY_DOMAIN_EXTENSIONS));
+ EXPECT_CALL(observer,
+ OnPolicyServiceInitialized(POLICY_DOMAIN_SIGNIN_EXTENSIONS));
Mock::VerifyAndClearExpectations(&provider1_);
EXPECT_CALL(provider1_, IsInitializationComplete(POLICY_DOMAIN_CHROME))
.WillRepeatedly(Return(true));
EXPECT_CALL(provider1_, IsInitializationComplete(POLICY_DOMAIN_EXTENSIONS))
.WillRepeatedly(Return(true));
+ EXPECT_CALL(provider1_,
+ IsInitializationComplete(POLICY_DOMAIN_SIGNIN_EXTENSIONS))
+ .WillRepeatedly(Return(true));
provider1_.UpdateChromePolicy(kPolicyMap);
Mock::VerifyAndClearExpectations(&observer);
EXPECT_TRUE(policy_service_->IsInitializationComplete(POLICY_DOMAIN_CHROME));
EXPECT_TRUE(
policy_service_->IsInitializationComplete(POLICY_DOMAIN_EXTENSIONS));
+ EXPECT_TRUE(policy_service_->IsInitializationComplete(
+ POLICY_DOMAIN_SIGNIN_EXTENSIONS));
// Cleanup.
policy_service_->RemoveObserver(POLICY_DOMAIN_CHROME, &observer);
policy_service_->RemoveObserver(POLICY_DOMAIN_EXTENSIONS, &observer);
+ policy_service_->RemoveObserver(POLICY_DOMAIN_SIGNIN_EXTENSIONS, &observer);
}
TEST_F(PolicyServiceTest, FixDeprecatedPolicies) {
« no previous file with comments | « components/policy/core/common/policy_namespace.h ('k') | components/policy/core/common/policy_test_utils.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698