Preserve the hardware read-only flag in Disk object.

chrome/browser/chromeos/file_manager/volume_manager_unittest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/file_manager/volume_manager.h"
 
 #include <stddef.h>
 
 #include <string>
 #include <vector>
@@ skipping 223 matching lines @@
   ASSERT_EQ(0U, observer.events().size());
   volume_manager()->RemoveObserver(&observer);
 }
 
 TEST_F(VolumeManagerTest, OnDiskEvent_Hidden) {
   LoggingObserver observer;
   volume_manager()->AddObserver(&observer);
 
   const bool kIsHidden = true;
   const chromeos::disks::DiskMountManager::Disk kDisk(
-      "device1", "", "", "", "", "", "", "", "", "", "", "",
+      "device1", "", false, "", "", "", "", "", "", "", "", "", "",
       chromeos::DEVICE_TYPE_UNKNOWN, 0, false, false, false, false, false,
       kIsHidden);
 
   volume_manager()->OnDiskEvent(
       chromeos::disks::DiskMountManager::DISK_ADDED, &kDisk);
   EXPECT_EQ(0U, observer.events().size());
 
   volume_manager()->OnDiskEvent(
       chromeos::disks::DiskMountManager::DISK_REMOVED, &kDisk);
   EXPECT_EQ(0U, observer.events().size());
 
   volume_manager()->OnDiskEvent(
       chromeos::disks::DiskMountManager::DISK_CHANGED, &kDisk);
   EXPECT_EQ(0U, observer.events().size());
 
   volume_manager()->RemoveObserver(&observer);
 }
 
 TEST_F(VolumeManagerTest, OnDiskEvent_Added) {
   // Enable external storage.
   profile()->GetPrefs()->SetBoolean(prefs::kExternalStorageDisabled, false);
 
   LoggingObserver observer;
   volume_manager()->AddObserver(&observer);
 
   const chromeos::disks::DiskMountManager::Disk kEmptyDevicePathDisk(
       "",  // empty device path.
-      "", "", "", "", "", "", "", "", "", "", "",
+      "", false, "", "", "", "", "", "", "", "", "", "",
       chromeos::DEVICE_TYPE_UNKNOWN, 0, false, false, false, false, false,
       false);
   volume_manager()->OnDiskEvent(
       chromeos::disks::DiskMountManager::DISK_ADDED, &kEmptyDevicePathDisk);
   EXPECT_EQ(0U, observer.events().size());
 
   const bool kHasMedia = true;
   const chromeos::disks::DiskMountManager::Disk kMediaDisk(
-      "device1", "", "", "", "", "", "", "", "", "", "", "",
+      "device1", "", false, "", "", "", "", "", "", "", "", "", "",
       chromeos::DEVICE_TYPE_UNKNOWN, 0, false, false, kHasMedia, false, false,
       false);
   volume_manager()->OnDiskEvent(
       chromeos::disks::DiskMountManager::DISK_ADDED, &kMediaDisk);
   ASSERT_EQ(1U, observer.events().size());
   const LoggingObserver::Event& event = observer.events()[0];
   EXPECT_EQ(LoggingObserver::Event::DISK_ADDED, event.type);
   EXPECT_EQ("device1", event.device_path);
   EXPECT_TRUE(event.mounting);
 
@@ skipping 12 matching lines @@
   // Enable external storage.
   profile()->GetPrefs()->SetBoolean(prefs::kExternalStorageDisabled, false);
 
   // Device which is already mounted.
   {
     LoggingObserver observer;
     volume_manager()->AddObserver(&observer);
 
     const bool kHasMedia = true;
     const chromeos::disks::DiskMountManager::Disk kMountedMediaDisk(
-        "device1", "mounted", "", "", "", "", "", "", "", "", "", "",
+        "device1", "mounted", false, "", "", "", "", "", "", "", "", "", "",
         chromeos::DEVICE_TYPE_UNKNOWN, 0, false, false,
         kHasMedia, false, false, false);
     volume_manager()->OnDiskEvent(
         chromeos::disks::DiskMountManager::DISK_ADDED, &kMountedMediaDisk);
     ASSERT_EQ(1U, observer.events().size());
     const LoggingObserver::Event& event = observer.events()[0];
     EXPECT_EQ(LoggingObserver::Event::DISK_ADDED, event.type);
     EXPECT_EQ("device1", event.device_path);
     EXPECT_FALSE(event.mounting);
 
     ASSERT_EQ(0U, disk_mount_manager_->mount_requests().size());
 
     volume_manager()->RemoveObserver(&observer);
   }
 
   // Device without media.
   {
     LoggingObserver observer;
     volume_manager()->AddObserver(&observer);
 
     const bool kWithoutMedia = false;
     const chromeos::disks::DiskMountManager::Disk kNoMediaDisk(
-        "device1", "", "", "", "", "", "", "", "", "", "", "",
+        "device1", "", false, "", "", "", "", "", "", "", "", "", "",
         chromeos::DEVICE_TYPE_UNKNOWN, 0, false, false,
         kWithoutMedia, false, false, false);
     volume_manager()->OnDiskEvent(
         chromeos::disks::DiskMountManager::DISK_ADDED, &kNoMediaDisk);
     ASSERT_EQ(1U, observer.events().size());
     const LoggingObserver::Event& event = observer.events()[0];
     EXPECT_EQ(LoggingObserver::Event::DISK_ADDED, event.type);
     EXPECT_EQ("device1", event.device_path);
     EXPECT_FALSE(event.mounting);
 
     ASSERT_EQ(0U, disk_mount_manager_->mount_requests().size());
 
     volume_manager()->RemoveObserver(&observer);
   }
 
   // External storage is disabled.
   {
     profile()->GetPrefs()->SetBoolean(prefs::kExternalStorageDisabled, true);
 
     LoggingObserver observer;
     volume_manager()->AddObserver(&observer);
 
     const bool kHasMedia = true;
     const chromeos::disks::DiskMountManager::Disk kMediaDisk(
-        "device1", "", "", "", "", "", "", "", "", "", "", "",
+        "device1", "", false, "", "", "", "", "", "", "", "", "", "",
         chromeos::DEVICE_TYPE_UNKNOWN, 0, false, false,
         kHasMedia, false, false, false);
     volume_manager()->OnDiskEvent(
         chromeos::disks::DiskMountManager::DISK_ADDED, &kMediaDisk);
     ASSERT_EQ(1U, observer.events().size());
     const LoggingObserver::Event& event = observer.events()[0];
     EXPECT_EQ(LoggingObserver::Event::DISK_ADDED, event.type);
     EXPECT_EQ("device1", event.device_path);
     EXPECT_FALSE(event.mounting);
 
     ASSERT_EQ(0U, disk_mount_manager_->mount_requests().size());
 
     volume_manager()->RemoveObserver(&observer);
   }
 }
 
 TEST_F(VolumeManagerTest, OnDiskEvent_Removed) {
   LoggingObserver observer;
   volume_manager()->AddObserver(&observer);
 
   const chromeos::disks::DiskMountManager::Disk kMountedDisk(
-      "device1", "mount_path", "", "", "", "", "", "", "", "", "", "",
+      "device1", "mount_path", false, "", "", "", "", "", "", "", "", "", "",
       chromeos::DEVICE_TYPE_UNKNOWN, 0, false, false, false, false, false,
       false);
   volume_manager()->OnDiskEvent(
       chromeos::disks::DiskMountManager::DISK_REMOVED, &kMountedDisk);
 
   ASSERT_EQ(1U, observer.events().size());
   const LoggingObserver::Event& event = observer.events()[0];
   EXPECT_EQ(LoggingObserver::Event::DISK_REMOVED, event.type);
   EXPECT_EQ("device1", event.device_path);
 
   ASSERT_EQ(1U, disk_mount_manager_->unmount_requests().size());
   const FakeDiskMountManager::UnmountRequest& unmount_request =
       disk_mount_manager_->unmount_requests()[0];
   EXPECT_EQ("mount_path", unmount_request.mount_path);
   EXPECT_EQ(chromeos::UNMOUNT_OPTIONS_LAZY, unmount_request.options);
 
   volume_manager()->RemoveObserver(&observer);
 }
 
 TEST_F(VolumeManagerTest, OnDiskEvent_RemovedNotMounted) {
   LoggingObserver observer;
   volume_manager()->AddObserver(&observer);
 
   const chromeos::disks::DiskMountManager::Disk kNotMountedDisk(
-      "device1", "", "", "", "", "", "", "", "", "", "", "",
+      "device1", "", false, "", "", "", "", "", "", "", "", "", "",
       chromeos::DEVICE_TYPE_UNKNOWN, 0, false, false, false, false, false,
       false);
   volume_manager()->OnDiskEvent(
       chromeos::disks::DiskMountManager::DISK_REMOVED, &kNotMountedDisk);
 
   ASSERT_EQ(1U, observer.events().size());
   const LoggingObserver::Event& event = observer.events()[0];
   EXPECT_EQ(LoggingObserver::Event::DISK_REMOVED, event.type);
   EXPECT_EQ("device1", event.device_path);
 
   ASSERT_EQ(0U, disk_mount_manager_->unmount_requests().size());
 
   volume_manager()->RemoveObserver(&observer);
 }
 
 TEST_F(VolumeManagerTest, OnDiskEvent_Changed) {
   // Changed event should cause mounting (if possible).
   LoggingObserver observer;
   volume_manager()->AddObserver(&observer);
 
   const chromeos::disks::DiskMountManager::Disk kDisk(
-      "device1", "", "", "", "", "", "", "", "", "", "", "",
+      "device1", "", false, "", "", "", "", "", "", "", "", "", "",
       chromeos::DEVICE_TYPE_UNKNOWN, 0, false, false, true, false, false,
       false);
   volume_manager()->OnDiskEvent(
       chromeos::disks::DiskMountManager::DISK_CHANGED, &kDisk);
 
   EXPECT_EQ(1U, observer.events().size());
   EXPECT_EQ(1U, disk_mount_manager_->mount_requests().size());
   EXPECT_EQ(0U, disk_mount_manager_->unmount_requests().size());
   // Read-write mode by default.
   EXPECT_EQ(chromeos::MOUNT_ACCESS_MODE_READ_WRITE,
             disk_mount_manager_->mount_requests()[0].access_mode);
 
   volume_manager()->RemoveObserver(&observer);
 }
 
 TEST_F(VolumeManagerTest, OnDiskEvent_ChangedInReadonly) {
   profile()->GetPrefs()->SetBoolean(prefs::kExternalStorageReadOnly, true);
 
   // Changed event should cause mounting (if possible).
   LoggingObserver observer;
   volume_manager()->AddObserver(&observer);
 
   const chromeos::disks::DiskMountManager::Disk kDisk(
-      "device1", "", "", "", "", "", "", "", "", "", "", "",
+      "device1", "", false, "", "", "", "", "", "", "", "", "", "",
       chromeos::DEVICE_TYPE_UNKNOWN, 0, false, false, true, false, false,
       false);
   volume_manager()->OnDiskEvent(chromeos::disks::DiskMountManager::DISK_CHANGED,
                                 &kDisk);
 
   EXPECT_EQ(1U, observer.events().size());
   EXPECT_EQ(1U, disk_mount_manager_->mount_requests().size());
   EXPECT_EQ(0U, disk_mount_manager_->unmount_requests().size());
   // Shoule mount a disk in read-only mode.
   EXPECT_EQ(chromeos::MOUNT_ACCESS_MODE_READ_ONLY,
@@ skipping 74 matching lines @@
   EXPECT_EQ(LoggingObserver::Event::VOLUME_UNMOUNTED, event.type);
   EXPECT_EQ("device1", event.device_path);
   EXPECT_EQ(chromeos::MOUNT_ERROR_NONE, event.mount_error);
 
   volume_manager()->RemoveObserver(&observer);
 }
 
 TEST_F(VolumeManagerTest, OnMountEvent_Remounting) {
   std::unique_ptr<chromeos::disks::DiskMountManager::Disk> disk(
       new chromeos::disks::DiskMountManager::Disk(
-          "device1", "", "", "", "", "", "", "", "", "", "uuid1", "",
+          "device1", "", false, "", "", "", "", "", "", "", "", "uuid1", "",
           chromeos::DEVICE_TYPE_UNKNOWN, 0, false, false, false, false, false,
           false));
   disk_mount_manager_->AddDiskForTest(std::move(disk));
   disk_mount_manager_->MountPath("device1", "", "", chromeos::MOUNT_TYPE_DEVICE,
                                  chromeos::MOUNT_ACCESS_MODE_READ_WRITE);
 
   const chromeos::disks::DiskMountManager::MountPointInfo kMountPoint(
       "device1",
       "mount1",
       chromeos::MOUNT_TYPE_DEVICE,
@@ skipping 189 matching lines @@
   profile()->GetPrefs()->SetBoolean(prefs::kExternalStorageDisabled, false);
   secondary.profile()->GetPrefs()->SetBoolean(prefs::kExternalStorageDisabled,
                                               true);
 
   LoggingObserver main_observer, secondary_observer;
   volume_manager()->AddObserver(&main_observer);
   secondary.volume_manager()->AddObserver(&secondary_observer);
 
   // Add 1 disk.
   const chromeos::disks::DiskMountManager::Disk kMediaDisk(
-      "device1", "", "", "", "", "", "", "", "", "", "", "",
+      "device1", "", false, "", "", "", "", "", "", "", "", "", "",
       chromeos::DEVICE_TYPE_UNKNOWN, 0, false, false, true, false, false,
       false);
   volume_manager()->OnDiskEvent(
       chromeos::disks::DiskMountManager::DISK_ADDED, &kMediaDisk);
   secondary.volume_manager()->OnDiskEvent(
       chromeos::disks::DiskMountManager::DISK_ADDED, &kMediaDisk);
 
   // The profile with external storage enabled should have mounted the volume.
   bool has_volume_mounted = false;
   for (size_t i = 0; i < main_observer.events().size(); ++i) {
@@ skipping 133 matching lines @@
   // Detach
   volume_manager()->OnRemovableStorageDetached(info);
   ASSERT_EQ(2u, observer.events().size());
   EXPECT_EQ(LoggingObserver::Event::VOLUME_UNMOUNTED,
             observer.events()[1].type);
 
   EXPECT_FALSE(volume.get());
 }
 
 }  // namespace file_manager