Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 2440413002: [regexp] Add regression test for v8:5434 (Closed)

Created:
4 years, 1 month ago by jgruber
Modified:
4 years, 1 month ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[regexp] Add regression test for v8:5434 The test ensures that in RegExp.prototype[@@split], exec is neither accessed too early nor too often. BUG=v8:5339, v8:5434 Committed: https://crrev.com/f87d73c7cf25bb921f06ffdc558ce16cf79daf8a Cr-Commit-Position: refs/heads/master@{#40526}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -0 lines) Patch
A test/mjsunit/regress/regress-5434.js View 1 chunk +42 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
jgruber
4 years, 1 month ago (2016-10-24 09:28:32 UTC) #5
Yang
On 2016/10/24 09:28:32, jgruber wrote: lgtm. thanks
4 years, 1 month ago (2016-10-24 10:31:15 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2440413002/1
4 years, 1 month ago (2016-10-24 10:33:46 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-24 10:38:23 UTC) #13
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:10:48 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f87d73c7cf25bb921f06ffdc558ce16cf79daf8a
Cr-Commit-Position: refs/heads/master@{#40526}

Powered by Google App Engine
This is Rietveld 408576698