Chromium Code Reviews
|
|
Chromium Code Reviews|
Created:
4 years, 1 month ago by jgruber Modified:
4 years, 1 month ago Reviewers:
Yang CC:
v8-reviews_googlegroups.com Target Ref:
refs/pending/heads/master Project:
v8 Visibility:
Public. |
Description[regexp] Add regression test for v8:5434
The test ensures that in RegExp.prototype[@@split], exec is neither
accessed too early nor too often.
BUG=v8:5339, v8:5434
Committed: https://crrev.com/f87d73c7cf25bb921f06ffdc558ce16cf79daf8a
Cr-Commit-Position: refs/heads/master@{#40526}
Patch Set 1 #
Created: 4 years, 1 month ago
Messages
Total messages: 15 (10 generated)
The CQ bit was checked by jgruber@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== [regexp] Add regression test for v8:5434 The test ensures that in RegExp.prototype[@@split], exec neither accessed too early nor too often. BUG=v8:5339 ========== to ========== [regexp] Add regression test for v8:5434 The test ensures that in RegExp.prototype[@@split], exec neither accessed too early nor too often. BUG=v8:5339,v8:5434 ==========
jgruber@chromium.org changed reviewers: + yangguo@chromium.org
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
On 2016/10/24 09:28:32, jgruber wrote: lgtm. thanks
Description was changed from ========== [regexp] Add regression test for v8:5434 The test ensures that in RegExp.prototype[@@split], exec neither accessed too early nor too often. BUG=v8:5339,v8:5434 ========== to ========== [regexp] Add regression test for v8:5434 The test ensures that in RegExp.prototype[@@split], exec is neither accessed too early nor too often. BUG=v8:5339,v8:5434 ==========
The CQ bit was checked by jgruber@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== [regexp] Add regression test for v8:5434 The test ensures that in RegExp.prototype[@@split], exec is neither accessed too early nor too often. BUG=v8:5339,v8:5434 ========== to ========== [regexp] Add regression test for v8:5434 The test ensures that in RegExp.prototype[@@split], exec is neither accessed too early nor too often. BUG=v8:5339,v8:5434 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== [regexp] Add regression test for v8:5434 The test ensures that in RegExp.prototype[@@split], exec is neither accessed too early nor too often. BUG=v8:5339,v8:5434 ========== to ========== [regexp] Add regression test for v8:5434 The test ensures that in RegExp.prototype[@@split], exec is neither accessed too early nor too often. BUG=v8:5339,v8:5434 Committed: https://crrev.com/f87d73c7cf25bb921f06ffdc558ce16cf79daf8a Cr-Commit-Position: refs/heads/master@{#40526} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/f87d73c7cf25bb921f06ffdc558ce16cf79daf8a Cr-Commit-Position: refs/heads/master@{#40526} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
