Make GroupedPermissionInfoBarDelegate's methods call through PermissionPromptAndroid

chrome/browser/permissions/permission_prompt_android.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/permissions/permission_prompt_android.h"
 
 #include "base/memory/ptr_util.h"
 #include "chrome/browser/infobars/infobar_service.h"
 #include "chrome/browser/media/webrtc/media_stream_devices_controller.h"
 #include "chrome/browser/permissions/grouped_permission_infobar_delegate_android.h"
@@ skipping 17 matching lines @@
 void PermissionPromptAndroid::Show(
     const std::vector<PermissionRequest*>& requests,
     const std::vector<bool>& values) {
   InfoBarService* infobar_service =
       InfoBarService::FromWebContents(web_contents_);
   if (!infobar_service)
     return;
 
   infobar_ = GroupedPermissionInfoBarDelegate::Create(
       infobar_service, requests[0]->GetOrigin(), requests);
+
+  GroupedPermissionInfoBarDelegate* infobar_delegate =
+      infobar_->delegate()->AsGroupedPermissionInfoBarDelegate();
+  infobar_delegate->SetPermissionPrompt(this);

[raymes, 2016/11/01 00:07:46]

Now that I look at it, I think passing this pointer in the constructor as you
had before is slightly better, because it means SetPermissionPrompt won't
accidentally be called multiple times.

[lshang, 2016/11/01 04:33:42]

Done.

 }
 
 bool PermissionPromptAndroid::CanAcceptRequestUpdate() {
   return false;
 }
 
 void PermissionPromptAndroid::Hide() {
   InfoBarService* infobar_service =
       InfoBarService::FromWebContents(web_contents_);
   if (infobar_ && infobar_service) {
     infobar_service->RemoveInfoBar(infobar_);
   }
+  GroupedPermissionInfoBarDelegate* infobar_delegate =
+      infobar_->delegate()->AsGroupedPermissionInfoBarDelegate();

[raymes, 2016/11/01 00:07:46]

I don't think we need to add this function, I think we can just static_cast the
infobar delegate to the GroupedPermissionInfobarDelegate because we know it will
be one of those.

[lshang, 2016/11/01 04:33:42]

Refer to other infobars, the convention seems to use a As***InfoBarDelegate() to
do the
downcasting(https://cs.chromium.org/chromium/src/components/infobars/core/infobar_delegate.h?l=213).


I don't feel strongly about it here, since we already use static_cast in
GroupedPermissionInfoBar::GetDelegate(), so proooobably it's ok?

Done.

[raymes, 2016/11/01 05:29:15]

If you know the type ahead of time (which I think in these cases we do, right?)
then a static cast is better because it avoids the virtual function call.

+  infobar_delegate->ResetPermissionPrompt();

[raymes, 2016/11/01 00:07:46]

Maybe this should just go in the destructor of this class? In terms of lifetimes
it should be safe to call as long as this class is alive, so it might make it
slightly clearer what's going on. You could also name the function
PermissionPromptDestroyed

[lshang, 2016/11/01 04:33:42]

Done.

   infobar_ = nullptr;
 }
 
 bool PermissionPromptAndroid::IsVisible() {
   return infobar_ != nullptr;
 }
 
 void PermissionPromptAndroid::UpdateAnchorPosition() {
   NOTREACHED() << "UpdateAnchorPosition is not implemented";
 }
 
 gfx::NativeWindow PermissionPromptAndroid::GetNativeWindow() {
   NOTREACHED() << "GetNativeWindow is not implemented";
   return nullptr;
 }
 
 void PermissionPromptAndroid::Closing() {
   infobar_ = nullptr;
   if (delegate_)
     delegate_->Closing();
 }
 
+void PermissionPromptAndroid::Accept() {
+  if (delegate_)
+    delegate_->Accept();
+}
+
+void PermissionPromptAndroid::Deny() {
+  if (delegate_)
+    delegate_->Deny();
+}
+
 // static
 std::unique_ptr<PermissionPrompt> PermissionPrompt::Create(
     content::WebContents* web_contents) {
   return base::MakeUnique<PermissionPromptAndroid>(web_contents);
 }