Use Mac fonts in Mac Chrome

Use Mac fonts in Mac Chrome.

Use Helvetica, Times, Courier, Apple Chancery, and Papyrus for sans-serif,
serif, monospace, cursive, and fantasy, respectively.  These are the fonts
used by Safari and Firefox on the Mac, and the fonts that we run layout tests
with on the Mac.

BUG=19135
21458
TEST=http://www.w3.org/Style/Examples/007/fonts
     Check the fonts for sans-serif, serif, monospace, cursive, fantasy
     Note that the font used for "Helvetica, sans-serif" is actually Verdana

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=27533

[Mark Mentovai, 2009-09-29 18:39:58]

The maybe-contentious part here is that I've had to set fallback_to_english,
which previously wasn't set for the messages in this file.

The alternative would be to put these new messages into all of the .xtb files,
but I'm not sure what values we should use for Eastern languages.  Also, I'm not
sure if we have a tool that will prime the .xtb files for these entries.  (We
should.  Do we?)

[TVL, 2009-09-29 18:43:46]

http://codereview.chromium.org/244039/diff/1001/2001
File chrome/app/resources/locale_settings.grd (right):

http://codereview.chromium.org/244039/diff/1001/2001#newcode308
Line 308: en-US,en
why do we need mac version of this?  do you just need to change the fonts?

[Mark Mentovai, 2009-09-29 18:47:18]

You asked me to keep the order in the file the same so as to not break
things.  I'll change it to break out of the <if> for these two and
then open a new <if> for the rest of the fonts.

On Tue, Sep 29, 2009 at 11:43 AM,  <thomasvl@chromium.org> wrote:
>
> http://codereview.chromium.org/244039/diff/1001/2001
> File chrome/app/resources/locale_settings.grd (right):
>
> http://codereview.chromium.org/244039/diff/1001/2001#newcode308
> Line 308: en-US,en
> why do we need mac version of this? =A0do you just need to change the
> fonts?
>
> http://codereview.chromium.org/244039
>

[TVL, 2009-09-29 18:51:43]

tony - do we need linux tweaks to any of this?  should we go ahead and rearrange
to get the fonts/sizes in one block so they can be tweaked for the platforms?

[tony, 2009-09-29 19:34:26]

Sharing with Windows is fine for now on Linux. Feel free to rearrange the file
to make it easier to read.

http://codereview.chromium.org/244039/diff/4002/4003
File chrome/app/resources/locale_settings.grd (right):

http://codereview.chromium.org/244039/diff/4002/4003#newcode222
Line 222: <messages fallback_to_english="true">
Everyone keeps asking why we don't do this, so I guess it's fine.  I think it's
better to have compile errors when we forget to update a file, but I guess I'm
the minority here.

We should do a follow up and remove unnecessary entries.

http://codereview.chromium.org/244039/diff/4002/4003#newcode237
Line 237: <if expr="os == 'darwin'">
Oh, ick.  I guess there's no way to change it for en-US (for other languages,
you can use <if> in the xtb file).

[Mark Mentovai, 2009-09-29 19:39:19]

http://codereview.chromium.org/244039/diff/4002/4003
File chrome/app/resources/locale_settings.grd (right):

http://codereview.chromium.org/244039/diff/4002/4003#newcode237
Line 237: <if expr="os == 'darwin'">
tony wrote:
> Oh, ick.  I guess there's no way to change it for en-US (for other languages,
> you can use <if> in the xtb file).

We should get different IDs on Mac and non-Mac, and at runtime we'll just pluck
the right entry out of the .pak based on ID without needing conditionals in the
.xtb, right?

[tony, 2009-09-29 19:47:47]

On 2009/09/29 19:39:19, Mark Mentovai wrote:
> http://codereview.chromium.org/244039/diff/4002/4003
> File chrome/app/resources/locale_settings.grd (right):
> 
> http://codereview.chromium.org/244039/diff/4002/4003#newcode237
> Line 237: <if expr="os == 'darwin'">
> tony wrote:
> > Oh, ick.  I guess there's no way to change it for en-US (for other
languages,
> > you can use <if> in the xtb file).
> 
> We should get different IDs on Mac and non-Mac, and at runtime we'll just
pluck
> the right entry out of the .pak based on ID without needing conditionals in
the
> .xtb, right?

Yes, they won't match in the xtb file because you don't have
use_name_for_id=true so they will all fallback to the default value in the grd
file.

Is there no variation in these values across languages in OSX?  If so, that's
fine.  But this approach won't let you handle different values per locale.

[Mark Mentovai, 2009-09-29 19:50:33]

Updated (the default font is checked in a unit test).