Turn extension script injection histograms into uma histograms....

Turn extension script injection histograms into uma histograms.

-Switch to UMA_HISTOGRAM_* macros.
-Rename to reflect that extensions are subsuming content scripts, and better fit the common style of histogram names. 
-Count css and scripts separately, and fix script count to account for multiple scripts per extension.


BUG=none
TEST=none

[asargent_no_longer_on_chrome, 2009-09-29 18:10:14]

aa: Please look at changes to counting number of scripts (in particular, does
this make sense given changes you'll be making for crbug.com/22110 ?)

jar: FYI on histogram type/name changes.

[jar (doing other things), 2009-09-29 20:55:02]

The histogram names LGTM.  See comment below about ranges.

http://codereview.chromium.org/244038/diff/1/2
File chrome/renderer/user_script_slave.cc (right):

http://codereview.chromium.org/244038/diff/1/2#newcode184
Line 184: UMA_HISTOGRAM_TIMES("Extensions.InjectEnd_Time", timer.Elapsed());
Note: This histogram has a maximum value of 10 seconds.  Unless you consistently
expect these times to be much smaller (sub-1-second?), you may want a histogram
with wider range.  Keep in mind that this will run on much slower computers in
the field.

See histogram.h for the clear spec of what each of these macros will do.

[Aaron Boodman, 2009-09-30 22:01:03]

lgtm

[asargent_no_longer_on_chrome, 2009-09-30 23:36:45]

http://codereview.chromium.org/244038/diff/1/2
File chrome/renderer/user_script_slave.cc (right):

http://codereview.chromium.org/244038/diff/1/2#newcode184
Line 184: UMA_HISTOGRAM_TIMES("Extensions.InjectEnd_Time", timer.Elapsed());
On 2009/09/29 20:55:02, jar wrote:
> Note: This histogram has a maximum value of 10 seconds.  Unless you
consistently
> expect these times to be much smaller (sub-1-second?), you may want a
histogram
> with wider range.  Keep in mind that this will run on much slower computers in
> the field.
> 
> See histogram.h for the clear spec of what each of these macros will do.

Thanks for the heads up. We expect these values to generally be less than
50-100ms, and anything over 1s to indicate a serious problem, so 10 seconds as
the max value should be fine.

[Aaron Boodman, 2009-10-07 01:31:39]

Can this issue be closed?

[asargent_no_longer_on_chrome, 2009-10-07 01:43:40]

For some reason lately gcl submit has been failing to close issues
automatically for me occasionally. I just closed it manually.

On Tue, Oct 6, 2009 at 6:31 PM, <aa@chromium.org> wrote:

> Can this issue be closed?
>
>
> http://codereview.chromium.org/244038
>