Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 2440333002: [turbofan] Fix typed lowering of JSToLength. (Closed)

Created:
4 years, 2 months ago by Benedikt Meurer
Modified:
4 years, 1 month ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Fix typed lowering of JSToLength. When lowering JSToLength, we cannot just smash arbitrary bounds on the Select nodes, as that will confuse the representation selection later. Instead properly rename the input using NumberMax and NumberMin. R=jarin@chromium.org BUG=chromium:657478 Committed: https://crrev.com/a58d7907ea0948e185ab2f41d22846d7a7563bc6 Cr-Commit-Position: refs/heads/master@{#40519}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -23 lines) Patch
M src/compiler/js-typed-lowering.cc View 1 chunk +4 lines, -15 lines 0 comments Download
A + test/mjsunit/regress/regress-crbug-657478.js View 1 chunk +5 lines, -8 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
Benedikt Meurer
4 years, 2 months ago (2016-10-24 04:10:33 UTC) #1
Benedikt Meurer
Hey Jaro, Here's a fix for the JSToLength lowering (the representation selection was confused how ...
4 years, 2 months ago (2016-10-24 04:11:45 UTC) #4
Jarin
lgtm
4 years, 2 months ago (2016-10-24 06:13:52 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2440333002/1
4 years, 2 months ago (2016-10-24 06:33:06 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-24 06:36:49 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:10:29 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a58d7907ea0948e185ab2f41d22846d7a7563bc6
Cr-Commit-Position: refs/heads/master@{#40519}

Powered by Google App Engine
This is Rietveld 408576698