Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issue 2440293002: [LayoutTests] Remove line and column of evaluate function (Closed)

Created:
4 years, 2 months ago by Clemens Hammacher
Modified:
4 years, 1 month ago
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, kozyatinskiy+blink_chromium.org, Michael Achenbach
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[LayoutTests] Remove line and column of evaluate function We had to rebaseline a test several times just because the script on V8 side changed. Excluding the position information of the evaluate method avoids this in the future. BUG=656622, 652939 R=kozyatinskiy@chromium.org,machenbach@chromium.org Committed: https://crrev.com/0990468b432a23ca258bca41ccc6c89cae8ee629 Cr-Commit-Position: refs/heads/master@{#427300}

Patch Set 1 #

Patch Set 2 : Remove android expected output #

Messages

Total messages: 18 (11 generated)
Clemens Hammacher
After all the trouble with rebaselining last week, I tought we would better fix it ...
4 years, 2 months ago (2016-10-23 15:15:41 UTC) #6
Michael Achenbach
I like it, but I'm not an owner. Like that we'll certainly have less trouble ...
4 years, 2 months ago (2016-10-24 06:34:38 UTC) #9
Clemens Hammacher
+jochen
4 years, 2 months ago (2016-10-24 08:01:59 UTC) #11
kozy
lgtm
4 years, 1 month ago (2016-10-24 17:30:26 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2440293002/20001
4 years, 1 month ago (2016-10-25 07:05:34 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-10-25 08:37:07 UTC) #16
commit-bot: I haz the power
4 years, 1 month ago (2016-10-25 08:40:29 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/0990468b432a23ca258bca41ccc6c89cae8ee629
Cr-Commit-Position: refs/heads/master@{#427300}

Powered by Google App Engine
This is Rietveld 408576698