|
|
DescriptionThis CL adds a layout test for an HTMLImageElement from another origin.
BUG=646083
TEST=third_party/WebKit/LayoutTests/http/tests/shapedetection/shapedetection-cross-origin.html
Committed: https://crrev.com/13e00c150a21aef90f089c7bcfd30af530b0656d
Cr-Commit-Position: refs/heads/master@{#427278}
Patch Set 1 : Add cross-origin test for shapedetection #
Total comments: 1
Patch Set 2 : mcasas@ comment #
Depends on Patchset: Messages
Total messages: 34 (29 generated)
The CQ bit was checked by xianglu@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Added cross-origin test for shapedetection BUG=646083 TEST=third_party/WebKit/LayoutTests/fast/shapedetection/shapedetection-security-test.html ========== to ========== Added cross-origin test for shapedetection BUG=646083 TEST=third_party/WebKit/LayoutTests/http/tests/shapedetection/shapedetection-cross-origin.html ==========
Description was changed from ========== Added cross-origin test for shapedetection BUG=646083 TEST=third_party/WebKit/LayoutTests/http/tests/shapedetection/shapedetection-cross-origin.html ========== to ========== This CL adds a layout test for an HTMLImageElement from another origin. BUG=646083 TEST=third_party/WebKit/LayoutTests/http/tests/shapedetection/shapedetection-cross-origin.html ==========
xianglu@chromium.org changed reviewers: + mcasas@chromium.org
ptal.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by xianglu@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by xianglu@chromium.org to run a CQ dry run
Patchset #2 (id:20001) has been deleted
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Patchset #1 (id:1) has been deleted
lgtm with a suggestion for further refactoring. https://codereview.chromium.org/2440243002/diff/40001/third_party/WebKit/Layo... File third_party/WebKit/LayoutTests/http/tests/shapedetection/shapedetection-cross-origin.html (right): https://codereview.chromium.org/2440243002/diff/40001/third_party/WebKit/Layo... third_party/WebKit/LayoutTests/http/tests/shapedetection/shapedetection-cross-origin.html:7: function detectFaceAndExpectError(imageUrl) { Could you add a TODO() here to move this helper function, that AFAIK is the same as in WebKit/LayoutTests/fast/shapedetection to a shared location, e.g. shapedetection_utils.js, that you will then include in l.4 and use here?
The CQ bit was checked by xianglu@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by xianglu@chromium.org to run a CQ dry run
Patchset #2 (id:60001) has been deleted
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Patchset #2 (id:80001) has been deleted
The CQ bit was checked by xianglu@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by xianglu@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from mcasas@chromium.org Link to the patchset: https://codereview.chromium.org/2440243002/#ps100001 (title: "mcasas@ comment")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== This CL adds a layout test for an HTMLImageElement from another origin. BUG=646083 TEST=third_party/WebKit/LayoutTests/http/tests/shapedetection/shapedetection-cross-origin.html ========== to ========== This CL adds a layout test for an HTMLImageElement from another origin. BUG=646083 TEST=third_party/WebKit/LayoutTests/http/tests/shapedetection/shapedetection-cross-origin.html ==========
Message was sent while issue was closed.
Committed patchset #2 (id:100001)
Message was sent while issue was closed.
Description was changed from ========== This CL adds a layout test for an HTMLImageElement from another origin. BUG=646083 TEST=third_party/WebKit/LayoutTests/http/tests/shapedetection/shapedetection-cross-origin.html ========== to ========== This CL adds a layout test for an HTMLImageElement from another origin. BUG=646083 TEST=third_party/WebKit/LayoutTests/http/tests/shapedetection/shapedetection-cross-origin.html Committed: https://crrev.com/13e00c150a21aef90f089c7bcfd30af530b0656d Cr-Commit-Position: refs/heads/master@{#427278} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/13e00c150a21aef90f089c7bcfd30af530b0656d Cr-Commit-Position: refs/heads/master@{#427278} |