Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Issue 2440243002: Shape Detection: Add cross-origin layout test for face detection (Closed)

Created:
4 years, 1 month ago by xianglu
Modified:
4 years, 1 month ago
Reviewers:
mcasas
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

This CL adds a layout test for an HTMLImageElement from another origin. BUG=646083 TEST=third_party/WebKit/LayoutTests/http/tests/shapedetection/shapedetection-cross-origin.html Committed: https://crrev.com/13e00c150a21aef90f089c7bcfd30af530b0656d Cr-Commit-Position: refs/heads/master@{#427278}

Patch Set 1 : Add cross-origin test for shapedetection #

Total comments: 1

Patch Set 2 : mcasas@ comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -0 lines) Patch
A third_party/WebKit/LayoutTests/http/tests/shapedetection/shapedetection-cross-origin.html View 1 1 chunk +40 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 34 (29 generated)
xianglu
ptal.
4 years, 1 month ago (2016-10-22 02:28:53 UTC) #6
mcasas
lgtm with a suggestion for further refactoring. https://codereview.chromium.org/2440243002/diff/40001/third_party/WebKit/LayoutTests/http/tests/shapedetection/shapedetection-cross-origin.html File third_party/WebKit/LayoutTests/http/tests/shapedetection/shapedetection-cross-origin.html (right): https://codereview.chromium.org/2440243002/diff/40001/third_party/WebKit/LayoutTests/http/tests/shapedetection/shapedetection-cross-origin.html#newcode7 third_party/WebKit/LayoutTests/http/tests/shapedetection/shapedetection-cross-origin.html:7: function detectFaceAndExpectError(imageUrl) ...
4 years, 1 month ago (2016-10-24 17:55:43 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2440243002/100001
4 years, 1 month ago (2016-10-25 04:54:36 UTC) #30
commit-bot: I haz the power
Committed patchset #2 (id:100001)
4 years, 1 month ago (2016-10-25 04:58:00 UTC) #32
commit-bot: I haz the power
4 years, 1 month ago (2016-10-25 05:02:47 UTC) #34
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/13e00c150a21aef90f089c7bcfd30af530b0656d
Cr-Commit-Position: refs/heads/master@{#427278}

Powered by Google App Engine
This is Rietveld 408576698