Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(339)

Side by Side Diff: third_party/WebKit/Source/modules/offscreencanvas2d/OffscreenCanvasRenderingContext2D.cpp

Issue 2440213003: Minor clean up in transferToImageBitmap API (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "modules/offscreencanvas2d/OffscreenCanvasRenderingContext2D.h" 5 #include "modules/offscreencanvas2d/OffscreenCanvasRenderingContext2D.h"
6 6
7 #include "bindings/modules/v8/OffscreenCanvasRenderingContext2DOrWebGLRenderingC ontextOrWebGL2RenderingContext.h" 7 #include "bindings/modules/v8/OffscreenCanvasRenderingContext2DOrWebGLRenderingC ontextOrWebGL2RenderingContext.h"
8 #include "core/frame/ImageBitmap.h" 8 #include "core/frame/ImageBitmap.h"
9 #include "core/frame/Settings.h" 9 #include "core/frame/Settings.h"
10 #include "core/workers/WorkerGlobalScope.h" 10 #include "core/workers/WorkerGlobalScope.h"
(...skipping 119 matching lines...) Expand 10 before | Expand all | Expand 10 after
130 if (!imageBuffer()) 130 if (!imageBuffer())
131 return nullptr; 131 return nullptr;
132 sk_sp<SkImage> skImage = m_imageBuffer->newSkImageSnapshot( 132 sk_sp<SkImage> skImage = m_imageBuffer->newSkImageSnapshot(
133 PreferAcceleration, SnapshotReasonTransferToImageBitmap); 133 PreferAcceleration, SnapshotReasonTransferToImageBitmap);
134 RefPtr<StaticBitmapImage> image = 134 RefPtr<StaticBitmapImage> image =
135 StaticBitmapImage::create(std::move(skImage)); 135 StaticBitmapImage::create(std::move(skImage));
136 image->setOriginClean(this->originClean()); 136 image->setOriginClean(this->originClean());
137 return image; 137 return image;
138 } 138 }
139 139
140 ImageBitmap* OffscreenCanvasRenderingContext2D::transferToImageBitmap( 140 ImageBitmap* OffscreenCanvasRenderingContext2D::transferToImageBitmap() {
141 ExceptionState& exceptionState) {
142 RefPtr<StaticBitmapImage> image = transferToStaticBitmapImage(); 141 RefPtr<StaticBitmapImage> image = transferToStaticBitmapImage();
143 if (!image) 142 if (!image)
144 return nullptr; 143 return nullptr;
145 m_imageBuffer.reset(); // "Transfer" means no retained buffer 144 m_imageBuffer.reset(); // "Transfer" means no retained buffer
146 m_needsMatrixClipRestore = true; 145 m_needsMatrixClipRestore = true;
147 return ImageBitmap::create(std::move(image)); 146 return ImageBitmap::create(std::move(image));
148 } 147 }
149 148
150 PassRefPtr<Image> OffscreenCanvasRenderingContext2D::getImage( 149 PassRefPtr<Image> OffscreenCanvasRenderingContext2D::getImage(
151 AccelerationHint hint, 150 AccelerationHint hint,
(...skipping 65 matching lines...) Expand 10 before | Expand all | Expand 10 after
217 } 216 }
218 217
219 bool OffscreenCanvasRenderingContext2D::isContextLost() const { 218 bool OffscreenCanvasRenderingContext2D::isContextLost() const {
220 return false; 219 return false;
221 } 220 }
222 221
223 bool OffscreenCanvasRenderingContext2D::isPaintable() const { 222 bool OffscreenCanvasRenderingContext2D::isPaintable() const {
224 return this->imageBuffer(); 223 return this->imageBuffer();
225 } 224 }
226 } 225 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698