Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(464)

Issue 2440203002: Mojo: removing support for process-group. (Closed)

Created:
4 years, 2 months ago by Jay Civelli
Modified:
4 years, 1 month ago
CC:
chromium-reviews, feature-media-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, jam, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin-cc_chromium.org, alokp+watch_chromium.org, darin (slow to review)
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mojo: removing support for process-group. Process groups are currently not used, removing them. BUG=658407 Committed: https://crrev.com/2fb1764136e5492e3d0d7f4fd9f45c91ef8f3d5a Cr-Commit-Position: refs/heads/master@{#428197}

Patch Set 1 #

Patch Set 2 : Synced #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -36 lines) Patch
M content/public/app/mojo/content_browser_manifest.json View 1 1 chunk +0 lines, -1 line 0 comments Download
M media/mojo/services/media_manifest.json View 1 1 chunk +0 lines, -1 line 0 comments Download
M services/catalog/data/connection_spec View 1 chunk +0 lines, -1 line 0 comments Download
M services/catalog/data/instance View 1 chunk +0 lines, -1 line 0 comments Download
M services/catalog/data/malformed View 1 chunk +0 lines, -1 line 0 comments Download
M services/catalog/data/serialization View 1 chunk +0 lines, -1 line 0 comments Download
M services/catalog/entry.h View 1 2 chunks +0 lines, -3 lines 0 comments Download
M services/catalog/entry.cc View 1 5 chunks +1 line, -17 lines 0 comments Download
M services/catalog/entry_unittest.cc View 1 2 chunks +0 lines, -3 lines 0 comments Download
M services/catalog/store.cc View 1 1 chunk +0 lines, -2 lines 0 comments Download
M services/file/manifest.json View 1 chunk +0 lines, -1 line 0 comments Download
M services/service_manager/public/tools/manifest/manifest_collator.py View 1 chunk +0 lines, -1 line 0 comments Download
M services/service_manager/tests/lifecycle/package_app_a_manifest.json View 1 chunk +0 lines, -1 line 0 comments Download
M services/service_manager/tests/lifecycle/package_app_b_manifest.json View 1 chunk +0 lines, -1 line 0 comments Download
M services/service_manager/tests/lifecycle/package_manifest.json View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 26 (15 generated)
Jay Civelli
4 years, 2 months ago (2016-10-21 21:23:33 UTC) #4
Ben Goodger (Google)
lgtm
4 years, 2 months ago (2016-10-21 21:32:46 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2440203002/1
4 years, 2 months ago (2016-10-22 00:23:04 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/287358)
4 years, 2 months ago (2016-10-22 01:08:14 UTC) #12
Jay Civelli
Adding @ochang for OWNERS review of content/public/app/mojo/content_browser_manifest.json
4 years, 2 months ago (2016-10-22 01:18:32 UTC) #14
Oliver Chang
lgtm
4 years, 1 month ago (2016-10-24 21:27:05 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2440203002/1
4 years, 1 month ago (2016-10-24 21:28:35 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/259063) linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, ...
4 years, 1 month ago (2016-10-24 22:55:03 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2440203002/20001
4 years, 1 month ago (2016-10-27 19:21:42 UTC) #22
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-10-27 23:17:08 UTC) #24
commit-bot: I haz the power
4 years, 1 month ago (2016-10-27 23:20:08 UTC) #26
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2fb1764136e5492e3d0d7f4fd9f45c91ef8f3d5a
Cr-Commit-Position: refs/heads/master@{#428197}

Powered by Google App Engine
This is Rietveld 408576698