Cleanup WebMIMERegistry implementation and fix LinkLoader behavior

Cleanup WebMIMERegistry implementation and fix LinkLoader behavior

- Now that content/child can also depend on media just implement
  media related mime methods in SimpleWebMIMERegistry and remove
  renderer-only overrides.

- LinkLoader should use supportsMediaMIMEType rather than
  supportsMediaSourceMIMEType in as=media cases, as the latter
  is for MediaSource extension and always fails if empty codecs
  string is given (and that was what happening in the real renderer case)

BUG=658628
TEST=http/tests/preload/preload_with_type.html
TEST=LinkLoaderTest.Preload

Committed: https://crrev.com/a7d224439f14b05798771fdf327fae51ae420664
Cr-Commit-Position: refs/heads/master@{#427037}

[kinuko, 2016-10-21 17:25:22]

The CQ bit was checked by kinuko@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-21 17:26:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kinuko, 2016-10-21 17:26:15]

Description was changed from

==========
Cleanup WebMIMERegistry implementation and fix LinkLoader behavior

- Now that content/child can also depend on media just implement
  media related mime methods in SimpleWebMIMERegistry and remove
  renderer-only overrides.

- LinkLoader should use supportsMediaMIMEType rather than
  supportsMediaSourceMIMEType in as=media cases, as the latter
  is for MediaSource extension and always fails if empty codecs
  string is given (and that was what happening in the real renderer case)

BUG=n/a
==========

to

==========
Cleanup WebMIMERegistry implementation and fix LinkLoader behavior

- Now that content/child can also depend on media just implement
  media related mime methods in SimpleWebMIMERegistry and remove
  renderer-only overrides.

- LinkLoader should use supportsMediaMIMEType rather than
  supportsMediaSourceMIMEType in as=media cases, as the latter
  is for MediaSource extension and always fails if empty codecs
  string is given (and that was what happening in the real renderer case)

BUG=n/a
==========

[kinuko, 2016-10-21 17:26:16]

kinuko@chromium.org changed reviewers:
+ yoav@yoav.ws

[kinuko, 2016-10-21 17:32:55]

Yoav, can you take a look?

https://codereview.chromium.org/2440163002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/loader/LinkLoader.cpp (right):

https://codereview.chromium.org/2440163002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/loader/LinkLoader.cpp:238: const String&
mimeType) {
looks like this could take mime parameters so we might actually want to parse
it... but I haven't taken the extra pass in this patch

[commit-bot: I haz the power, 2016-10-21 19:15:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-21 19:15:04]

Dry run: This issue passed the CQ dry run.

[Yoav Weiss, 2016-10-23 14:57:49]

On 2016/10/21 17:32:55, kinuko wrote:
> Yoav, can you take a look?
> 
>
https://codereview.chromium.org/2440163002/diff/20001/third_party/WebKit/Sour...
> File third_party/WebKit/Source/core/loader/LinkLoader.cpp (right):
> 
>
https://codereview.chromium.org/2440163002/diff/20001/third_party/WebKit/Sour...
> third_party/WebKit/Source/core/loader/LinkLoader.cpp:238: const String&
> mimeType) {
> looks like this could take mime parameters so we might actually want to parse
> it... but I haven't taken the extra pass in this patch

Code changes look good. Can you add a test that demonstrates the fix and makes
sure it doesn't regress? Could you also open an issue related to it?

[kinuko, 2016-10-24 01:48:30]

The CQ bit was checked by kinuko@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-24 01:48:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kinuko, 2016-10-24 03:09:49]

Description was changed from

==========
Cleanup WebMIMERegistry implementation and fix LinkLoader behavior

- Now that content/child can also depend on media just implement
  media related mime methods in SimpleWebMIMERegistry and remove
  renderer-only overrides.

- LinkLoader should use supportsMediaMIMEType rather than
  supportsMediaSourceMIMEType in as=media cases, as the latter
  is for MediaSource extension and always fails if empty codecs
  string is given (and that was what happening in the real renderer case)

BUG=n/a
==========

to

==========
Cleanup WebMIMERegistry implementation and fix LinkLoader behavior

- Now that content/child can also depend on media just implement
  media related mime methods in SimpleWebMIMERegistry and remove
  renderer-only overrides.

- LinkLoader should use supportsMediaMIMEType rather than
  supportsMediaSourceMIMEType in as=media cases, as the latter
  is for MediaSource extension and always fails if empty codecs
  string is given (and that was what happening in the real renderer case)

BUG=658628
TEST=http/tests/preload/preload_with_type.html
TEST=LinkLoaderTest.Preload
==========

[kinuko, 2016-10-24 03:11:03]

On 2016/10/23 14:57:49, Yoav Weiss wrote:
> On 2016/10/21 17:32:55, kinuko wrote:
> > Yoav, can you take a look?
> > 
> >
>
https://codereview.chromium.org/2440163002/diff/20001/third_party/WebKit/Sour...
> > File third_party/WebKit/Source/core/loader/LinkLoader.cpp (right):
> > 
> >
>
https://codereview.chromium.org/2440163002/diff/20001/third_party/WebKit/Sour...
> > third_party/WebKit/Source/core/loader/LinkLoader.cpp:238: const String&
> > mimeType) {
> > looks like this could take mime parameters so we might actually want to
parse
> > it... but I haven't taken the extra pass in this patch
> 
> Code changes look good. Can you add a test that demonstrates the fix and makes
> sure it doesn't regress? Could you also open an issue related to it?

Sure, added a layout test, which fails without this patch.  (Existing
LinkLoaderTest should also catch this with the testharness fix in this patch)
PTAL

[commit-bot: I haz the power, 2016-10-24 03:25:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-24 03:25:30]

Dry run: This issue passed the CQ dry run.

[Yoav Weiss, 2016-10-24 07:10:41]

On 2016/10/24 03:11:03, kinuko wrote:
> On 2016/10/23 14:57:49, Yoav Weiss wrote:
> > On 2016/10/21 17:32:55, kinuko wrote:
> > > Yoav, can you take a look?
> > > 
> > >
> >
>
https://codereview.chromium.org/2440163002/diff/20001/third_party/WebKit/Sour...
> > > File third_party/WebKit/Source/core/loader/LinkLoader.cpp (right):
> > > 
> > >
> >
>
https://codereview.chromium.org/2440163002/diff/20001/third_party/WebKit/Sour...
> > > third_party/WebKit/Source/core/loader/LinkLoader.cpp:238: const String&
> > > mimeType) {
> > > looks like this could take mime parameters so we might actually want to
> parse
> > > it... but I haven't taken the extra pass in this patch
> > 
> > Code changes look good. Can you add a test that demonstrates the fix and
makes
> > sure it doesn't regress? Could you also open an issue related to it?
> 
> Sure, added a layout test, which fails without this patch.  (Existing
> LinkLoaderTest should also catch this with the testharness fix in this patch)
> PTAL

Thank you for adding the tests! :)

core/ LGTM

Non-owner LGTM for the rest

[kinuko, 2016-10-24 09:47:56]

The CQ bit was checked by kinuko@chromium.org

[commit-bot: I haz the power, 2016-10-24 09:48:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-24 10:03:02]

Description was changed from

==========
Cleanup WebMIMERegistry implementation and fix LinkLoader behavior

- Now that content/child can also depend on media just implement
  media related mime methods in SimpleWebMIMERegistry and remove
  renderer-only overrides.

- LinkLoader should use supportsMediaMIMEType rather than
  supportsMediaSourceMIMEType in as=media cases, as the latter
  is for MediaSource extension and always fails if empty codecs
  string is given (and that was what happening in the real renderer case)

BUG=658628
TEST=http/tests/preload/preload_with_type.html
TEST=LinkLoaderTest.Preload
==========

to

==========
Cleanup WebMIMERegistry implementation and fix LinkLoader behavior

- Now that content/child can also depend on media just implement
  media related mime methods in SimpleWebMIMERegistry and remove
  renderer-only overrides.

- LinkLoader should use supportsMediaMIMEType rather than
  supportsMediaSourceMIMEType in as=media cases, as the latter
  is for MediaSource extension and always fails if empty codecs
  string is given (and that was what happening in the real renderer case)

BUG=658628
TEST=http/tests/preload/preload_with_type.html
TEST=LinkLoaderTest.Preload
==========

[commit-bot: I haz the power, 2016-10-24 10:03:03]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-10-24 10:05:42]

Description was changed from

==========
Cleanup WebMIMERegistry implementation and fix LinkLoader behavior

- Now that content/child can also depend on media just implement
  media related mime methods in SimpleWebMIMERegistry and remove
  renderer-only overrides.

- LinkLoader should use supportsMediaMIMEType rather than
  supportsMediaSourceMIMEType in as=media cases, as the latter
  is for MediaSource extension and always fails if empty codecs
  string is given (and that was what happening in the real renderer case)

BUG=658628
TEST=http/tests/preload/preload_with_type.html
TEST=LinkLoaderTest.Preload
==========

to

==========
Cleanup WebMIMERegistry implementation and fix LinkLoader behavior

- Now that content/child can also depend on media just implement
  media related mime methods in SimpleWebMIMERegistry and remove
  renderer-only overrides.

- LinkLoader should use supportsMediaMIMEType rather than
  supportsMediaSourceMIMEType in as=media cases, as the latter
  is for MediaSource extension and always fails if empty codecs
  string is given (and that was what happening in the real renderer case)

BUG=658628
TEST=http/tests/preload/preload_with_type.html
TEST=LinkLoaderTest.Preload

Committed: https://crrev.com/a7d224439f14b05798771fdf327fae51ae420664
Cr-Commit-Position: refs/heads/master@{#427037}
==========

[commit-bot: I haz the power, 2016-10-24 10:05:43]

Patchset 3 (id:??) landed as
https://crrev.com/a7d224439f14b05798771fdf327fae51ae420664
Cr-Commit-Position: refs/heads/master@{#427037}