Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(836)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2440113003: Exit gen_snapshot and log an error if an output file path is invalid (Closed)

Created:
4 years, 2 months ago by jsimmons1
Modified:
4 years, 2 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Exit gen_snapshot and log an error if an output file path is invalid BUG= R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/7c14d5e7d7b2c51bf2a9431555bfd07ac4560841

Patch Set 1 #

Total comments: 1

Patch Set 2 : Exit gen_snapshot and log an error if an output file path is invalid #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M runtime/bin/gen_snapshot.cc View 1 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
jsimmons1
4 years, 2 months ago (2016-10-21 22:28:32 UTC) #3
rmacnak
lgtm https://codereview.chromium.org/2440113003/diff/1/runtime/bin/gen_snapshot.cc File runtime/bin/gen_snapshot.cc (right): https://codereview.chromium.org/2440113003/diff/1/runtime/bin/gen_snapshot.cc#newcode389 runtime/bin/gen_snapshot.cc:389: exit(255); kErrorExitCode
4 years, 2 months ago (2016-10-21 22:34:31 UTC) #4
jsimmons1
On 2016/10/21 22:34:31, rmacnak wrote: > lgtm > > https://codereview.chromium.org/2440113003/diff/1/runtime/bin/gen_snapshot.cc > File runtime/bin/gen_snapshot.cc (right): > ...
4 years, 2 months ago (2016-10-21 22:47:52 UTC) #5
rmacnak
4 years, 2 months ago (2016-10-21 23:04:38 UTC) #7
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
7c14d5e7d7b2c51bf2a9431555bfd07ac4560841 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698