Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(411)

Issue 2440063002: Worker: Make WorkerThread inherit WebThread::TaskObserver instead of WorkerMicrotaskRunner (Closed)

Created:
4 years, 2 months ago by nhiroki
Modified:
4 years, 1 month ago
Reviewers:
falken, yhirano
CC:
chromium-reviews, shimazu+worker_chromium.org, kinuko+worker_chromium.org, blink-reviews, horo+watch_chromium.org, falken+watch_chromium.org, blink-worker-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Worker: Make WorkerThread inherit WebThread::TaskObserver instead of WorkerMicrotaskRunner For cleanup, this CL makes WorkerThread inherit WebThread::TaskObserver and removes WorkerMicrotaskRunner that is used for observing WebThread activities and forwarding them to WorkerThread. BUG=n/a Committed: https://crrev.com/cdb1f357fea7ae0d3041cd825975d6d06047019f Cr-Commit-Position: refs/heads/master@{#427024}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -47 lines) Patch
M third_party/WebKit/Source/core/workers/WorkerThread.h View 5 chunks +6 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/workers/WorkerThread.cpp View 6 chunks +28 lines, -44 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
nhiroki
PTAL, thanks!
4 years, 2 months ago (2016-10-21 05:38:43 UTC) #3
yhirano
lgtm
4 years, 1 month ago (2016-10-24 03:42:46 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2440063002/1
4 years, 1 month ago (2016-10-24 03:46:33 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-24 07:05:17 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-10-24 07:08:43 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cdb1f357fea7ae0d3041cd825975d6d06047019f
Cr-Commit-Position: refs/heads/master@{#427024}

Powered by Google App Engine
This is Rietveld 408576698