Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issue 2440043003: nc seal breaks simplify (Closed)

Created:
4 years, 2 months ago by caryclark
Modified:
4 years, 1 month ago
Reviewers:
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

nc seal breaks simplify This test has nearly coincident lines that are missorted. The underlying bug is caused when a pair of curves are coincident when reduced to line segments, but the end points aren't detected. The error was generated by running nanobench over all svg sample data with the distance field patch installed. TBR=reed@google.com GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2440043003 Committed: https://skia.googlesource.com/skia/+/34efb7039851d7796ba06aa58e5c5882ede503ac

Patch Set 1 #

Patch Set 2 : fix nc state seal #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1368 lines, -1369 lines) Patch
M src/pathops/SkPathOpsTSect.h View 1 8 chunks +23 lines, -5 lines 0 comments Download
M tests/PathOpsQuadIntersectionTest.cpp View 1 1 chunk +3 lines, -0 lines 0 comments Download
M tests/PathOpsSimplifyTest.cpp View 1 1 chunk +47 lines, -1 line 0 comments Download
M tools/pathops_sorter.htm View 1 1 chunk +12 lines, -5 lines 0 comments Download
M tools/pathops_visualizer.htm View 1 chunk +1283 lines, -1358 lines 0 comments Download

Messages

Total messages: 7 (5 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2440043003/20001
4 years, 1 month ago (2016-10-24 14:13:55 UTC) #5
commit-bot: I haz the power
4 years, 1 month ago (2016-10-24 15:19:09 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/34efb7039851d7796ba06aa58e5c5882ede503ac

Powered by Google App Engine
This is Rietveld 408576698