Support NSFlagsChanged in ui::EventFromNative.

ui/events/cocoa/events_mac_unittest.mm

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
+#import <Carbon/Carbon.h>
 #import <Cocoa/Cocoa.h>
 #include <stdint.h>
 
 #include <memory>
+#include <utility>
 
 #include "base/mac/scoped_cftyperef.h"
 #include "base/mac/sdk_forward_declarations.h"
 #include "base/macros.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #import "ui/events/cocoa/cocoa_event_utils.h"
 #include "ui/events/event_constants.h"
 #include "ui/events/event_utils.h"
 #import "ui/events/test/cocoa_test_event_utils.h"
 #include "ui/gfx/geometry/point.h"
@@ skipping 471 matching lines @@
     ui::ScrollEvent update(ns_events[4]);
     EXPECT_EQ(ui::EventMomentumPhase::INERTIAL_UPDATE, update.momentum_phase());
     EXPECT_EQ(momentum_delta_y, update.y_offset_ordinal());
 
     ui::ScrollEvent end(ns_events[5]);
     EXPECT_EQ(ui::EventMomentumPhase::END, end.momentum_phase());
     EXPECT_EQ(0, end.y_offset_ordinal());
   }
 }
 
+TEST_F(EventsMacTest, NSFlagsChanged) {

[tapted, 2016/10/25 06:55:10]

test should have a comment above describing its purpose

[alshabalin, 2016/10/28 19:58:13]

Done.

+  struct {
+    NSEventModifierFlags modifierFlags;

[tapted, 2016/10/25 06:55:10]

this isn't between @implementation/@end, so we should use hacker_style (i.e.
modifier_flags - same for those below)

[alshabalin, 2016/10/28 19:58:13]

Done.

+    uint16_t keyCode;
+    EventType expectedType;
+    KeyboardCode expectedKeyboardCode;
+  } test_cases[] = {
+      // CapsLock.

[tapted, 2016/10/25 06:55:10]

optional: Perhaps include a const char* member, and put this comment in that
then...

[alshabalin, 2016/10/28 19:58:13]

Good idea, thanks! Done.

+      {NSAlphaShiftKeyMask, kVK_CapsLock, ET_KEY_PRESSED, VKEY_CAPITAL},
+      {0, kVK_CapsLock, ET_KEY_RELEASED, VKEY_CAPITAL},
+      // Shift.
+      {NSShiftKeyMask, kVK_Shift, ET_KEY_PRESSED, VKEY_SHIFT},
+      {0, kVK_Shift, ET_KEY_RELEASED, VKEY_SHIFT},
+      // Control.
+      {NSControlKeyMask, kVK_Control, ET_KEY_PRESSED, VKEY_CONTROL},
+      {0, kVK_Control, ET_KEY_RELEASED, VKEY_CONTROL},
+      // Option.
+      {NSAlternateKeyMask, kVK_Option, ET_KEY_PRESSED, VKEY_MENU},
+      {0, kVK_Option, ET_KEY_RELEASED, VKEY_MENU},
+      // Command.
+      {NSCommandKeyMask, kVK_Command, ET_KEY_PRESSED, VKEY_LWIN},
+      {0, kVK_Command, ET_KEY_RELEASED, VKEY_LWIN},
+      // Shift + CapsLock.
+      {NSShiftKeyMask | NSAlphaShiftKeyMask, kVK_Shift, ET_KEY_PRESSED,
+       VKEY_SHIFT},
+      {NSAlphaShiftKeyMask, kVK_Shift, ET_KEY_RELEASED, VKEY_SHIFT},
+  };
+  for (size_t i = 0; i < arraysize(test_cases); ++i) {

[tapted, 2016/10/25 06:55:10]

..then here I think you can do `for (const auto& test_case : test_cases) {` and
you don't need the line below

+    const auto& test_case = test_cases[i];
+    SCOPED_TRACE(::testing::Message() << "While checking case #" << i);

[tapted, 2016/10/25 06:55:09]

... and here output the const char*

+    NSEvent* nativeEvent = cocoa_test_event_utils::KeyEventWithModifierOnly(

[tapted, 2016/10/25 06:55:10]

native_event, or ns_event

[alshabalin, 2016/10/28 19:58:13]

Done.

+        test_case.keyCode, test_case.modifierFlags);
+    auto event = EventFromNative(nativeEvent);

[tapted, 2016/10/25 06:55:10]

this isn't a good use of `auto` per
https://google.github.io/styleguide/cppguide.html#auto - use
std::unique_ptr<Event> event

[alshabalin, 2016/10/28 19:58:14]

Done.

+    EXPECT_TRUE(event);
+    EXPECT_EQ(test_case.expectedType, event->type());
+    EXPECT_EQ(test_case.expectedKeyboardCode, event->AsKeyEvent()->key_code());
+  }
+}
+
 }  // namespace ui