Support NSFlagsChanged in ui::EventFromNative.

ui/events/cocoa/events_mac.mm

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/events/event_utils.h"
 
 #include <Cocoa/Cocoa.h>
 #include <stdint.h>
 
 #include "base/logging.h"
 #import "base/mac/mac_util.h"
 #import "base/mac/sdk_forward_declarations.h"
 #include "base/time/time.h"
 #include "build/build_config.h"
 #include "ui/events/base_event_utils.h"
 #include "ui/events/cocoa/cocoa_event_utils.h"
 #include "ui/events/event_utils.h"
 #import "ui/events/keycodes/keyboard_code_conversion_mac.h"
 #include "ui/gfx/geometry/point.h"
 #include "ui/gfx/geometry/vector2d.h"
 
 namespace ui {
 
+namespace {
+
+EventType EventTypeForFlagsChanged(NSEventModifierFlags flags,
+                                   KeyboardCode key_code) {
+  switch (key_code) {
+    case VKEY_CAPITAL:

[tapted, 2016/10/25 06:55:09]

There's no need to use the Windows keycodes that KeyboardCodeFromNSEvent gives -
here we can switch on kVK_CapsLock, kVK_[Right]Shift, kVK_[Right]Control,
kVK_[Right]Option, kVK_[Right]Command

Just pass [native_event keyCode]

you might need to #include Carbon

+      return (flags & NSAlphaShiftKeyMask) ? ET_KEY_PRESSED : ET_KEY_RELEASED;
+    case VKEY_SHIFT:
+      return (flags & NSShiftKeyMask) ? ET_KEY_PRESSED : ET_KEY_RELEASED;
+    case VKEY_CONTROL:
+      return (flags & NSControlKeyMask) ? ET_KEY_PRESSED : ET_KEY_RELEASED;
+    case VKEY_MENU:
+      return (flags & NSAlternateKeyMask) ? ET_KEY_PRESSED : ET_KEY_RELEASED;
+    case VKEY_APPS:  // Fallthrough.
+    case VKEY_LWIN:
+      return (flags & NSCommandKeyMask) ? ET_KEY_PRESSED : ET_KEY_RELEASED;
+    default:
+      return ET_UNKNOWN;
+  }
+}
+
+}  // namespace
+
 EventType EventTypeFromNative(const base::NativeEvent& native_event) {
   NSEventType type = [native_event type];
   switch (type) {
     case NSKeyDown:
       return ET_KEY_PRESSED;
     case NSKeyUp:
       return ET_KEY_RELEASED;
     case NSLeftMouseDown:
     case NSRightMouseDown:
     case NSOtherMouseDown:
@@ skipping 13 matching lines @@
     case NSMouseEntered:
       return ET_MOUSE_ENTERED;
     case NSMouseExited:
       return ET_MOUSE_EXITED;
     case NSEventTypeSwipe:
       return ET_SCROLL_FLING_START;
     case NSAppKitDefined:
     case NSSystemDefined:
       return ET_UNKNOWN;
     case NSFlagsChanged:
+      return EventTypeForFlagsChanged(native_event.modifierFlags,

[tapted, 2016/10/25 06:55:09]

[native_event modifierFlags]  - we only use dot notation for structs

[tapted, 2016/10/27 00:33:05]

And here just have

  case NSKeyDown:
  case NSKeyUp:
  case NSFlagsChanged:
    return IsKeyUpEvent(native_event) ? ET_KEY_RELEASED : ET_KEY_PRESSED;

[alshabalin, 2016/10/28 19:58:13]

Done.

+                                      KeyboardCodeFromNSEvent(native_event));
     case NSApplicationDefined:
     case NSPeriodic:
     case NSCursorUpdate:
     case NSTabletPoint:
     case NSTabletProximity:
     case NSEventTypeGesture:
     case NSEventTypeMagnify:
     case NSEventTypeRotate:
     case NSEventTypeBeginGesture:
     case NSEventTypeEndGesture:
@@ skipping 233 matching lines @@
   uint16_t return_value;
   [text getCharacters:&return_value];
   return return_value;
 }
 
 bool IsCharFromNative(const base::NativeEvent& native_event) {
   return false;
 }
 
 }  // namespace ui