Issue 24398002: GTTF: instantiate ThreadChecker early in the test launcher

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 24398002: GTTF: instantiate ThreadChecker early in the test launcher (Closed)

Created:
7 years, 3 months ago by Paweł Hajdan Jr.

Modified:
7 years, 3 months ago

Reviewers:
sky

CC:
chromium-reviews, erikwright+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

GTTF: instantiate ThreadChecker early in the test launcher This makes sure it's also available during destructions. While the immediate problem happened only with ParallelTestLauncher, I'm proactively fixing similar pattern in other places. BUG=236893 R=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=224838

Patch Set 1 #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+11 lines, -8 lines)			Patch
M	base/test/parallel_test_launcher.h	View	2 chunks	+7 lines, -4 lines	0 comments	Download
M	base/test/test_launcher.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	base/test/unit_test_launcher.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Paweł Hajdan Jr.

7 years, 3 months ago (2013-09-23 23:49:07 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r224838 (presubmit successful).

Expand Messages | Collapse Messages