Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1000)

Issue 2439773002: Deprecate ToSourceVisitor (Closed)

Created:
4 years, 2 months ago by Brian Wilkerson
Modified:
4 years, 2 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Deprecate PrintStringWriter too #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -4 lines) Patch
M pkg/analyzer/lib/src/dart/ast/ast.dart View 2 chunks +3 lines, -4 lines 0 comments Download
M pkg/analyzer/lib/src/dart/ast/utilities.dart View 1 chunk +3 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/generated/java_core.dart View 1 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analyzer/test/src/dart/ast/utilities_test.dart View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Brian Wilkerson
4 years, 2 months ago (2016-10-20 14:57:03 UTC) #2
scheglov
LGTM
4 years, 2 months ago (2016-10-20 15:37:48 UTC) #3
Brian Wilkerson
4 years, 2 months ago (2016-10-20 15:38:26 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
d42a22bb1db3c4899f6c5cbb92b62d63f416585e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698